Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Twig 2 #15313

Merged
merged 1 commit into from Jun 8, 2019
Merged

Conversation

MauricioFauth
Copy link
Member

@MauricioFauth MauricioFauth commented Jun 8, 2019

Description

Adds support for Twig 2 in QA_4_9 branch to help package maintainers who wants to use PHP 7.

Twig 2 has a lot of backward compatibility with Twig 1, so this upgrade is probably safe.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
@codecov
Copy link

codecov bot commented Jun 8, 2019

Codecov Report

Merging #15313 into QA_4_9 will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             QA_4_9   #15313   +/-   ##
=========================================
  Coverage     55.59%   55.59%           
  Complexity    14498    14498           
=========================================
  Files           494      494           
  Lines         71045    71045           
=========================================
  Hits          39494    39494           
  Misses        31551    31551

1 similar comment
@codecov
Copy link

codecov bot commented Jun 8, 2019

Codecov Report

Merging #15313 into QA_4_9 will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             QA_4_9   #15313   +/-   ##
=========================================
  Coverage     55.59%   55.59%           
  Complexity    14498    14498           
=========================================
  Files           494      494           
  Lines         71045    71045           
=========================================
  Hits          39494    39494           
  Misses        31551    31551

@MauricioFauth MauricioFauth merged commit 665e385 into phpmyadmin:QA_4_9 Jun 8, 2019
@MauricioFauth MauricioFauth deleted the twig2-4.9 branch June 8, 2019 18:20
@MauricioFauth MauricioFauth self-assigned this Jun 8, 2019
@MauricioFauth MauricioFauth added this to the 4.9.1 milestone Jun 8, 2019
MauricioFauth added a commit that referenced this pull request Jun 8, 2019
Add support for Twig 2

[ci skip]

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
MauricioFauth added a commit that referenced this pull request Jun 19, 2019
Related to #15313

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants