Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring designer #15314

Conversation

Projects
None yet
4 participants
@Bournvita1998
Copy link
Contributor

commented Jun 8, 2019

Description

Removed vanilla js and added jQuery at several places
Signed-off-by: Mohit Kuri mohit.kuri@research.iiit.ac.in

Fixes #

Before submitting pull request, please review the following checklist:

  • Make sure you have read our CONTRIBUTING.md document.
  • Make sure you are making a pull request against the correct branch. For example, for bug fixes in a released version use the corresponding QA branch and for new features use the master branch. If you have a doubt, you can ask as a comment in the bug report or on the mailing list.
  • Every commit has proper Signed-off-by line as described in our DCO. This ensures that the work you're submitting is your own creation.
  • Every commit has a descriptive commit message.
  • Every commit is needed on its own, if you have just minor fixes to previous commits, you can squash them.
  • Any new functionality is covered by tests.

Bournvita1998 added some commits Jun 3, 2019

resolving some issues which I realised while creating PR
Signed-off-by: Bournvita1998 <mohit.kuri@research.iiit.ac.in>
@phpmyadmin-bot

This comment has been minimized.

Copy link

commented on 0f3089e Jun 3, 2019

This commit is missing Signed-Off-By line to indicate that you agree with phpMyAdmin Developer's Certificate of Origin. Please check contributing documentation for more information.

Bournvita1998 added some commits Jun 4, 2019

Reverting a few changes
Signed-off-by: Bournvita1998 <mohit.kuri@research.iiit.ac.in>
fixing ESLint error
Signed-off-by: Mohit Kuri <mohit.kuri@research.iiit.ac.in>
Changing the variable names and resolving other issues
Signed-off-by: Bournvita1998 <mohit.kuri@research.iiit.ac.in>
changing the signatures
Signed-off-by: Mohit Kuri <mohit.kuri@research.iiit.ac.in>
Refactoring js/designer/history.js
Signed-off-by: Mohit Kuri <mohit.kuri@research.iiit.ac.in>
@mauriciofauth

This comment has been minimized.

Copy link
Member

commented Jun 8, 2019

Can you squash your commits and rebase with the latest changes in gsoc-db-designer branch?

@Bournvita1998

This comment has been minimized.

Copy link
Contributor Author

commented Jun 8, 2019

@mauriciofauth Okay I will do that.

@shucon

This comment has been minimized.

Copy link
Contributor

commented Jun 9, 2019

@Bournvita1998

This comment has been minimized.

Copy link
Contributor Author

commented Jun 9, 2019

@mauriciofauth @shucon I have created a new PR for refactoring designer. It's because when I was trying to squash with 9 commit messages, I don't know how but it was showing 784 commits in the next window which we get after entering the command on terminal.

You can have a look at that here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.