Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

applied bootstrap grid structure on settings page. #15320

Open
wants to merge 10 commits into
base: master
from

Conversation

Projects
None yet
3 participants
@murex971
Copy link
Contributor

commented Jun 10, 2019

Signed-off-by: Nupur Agrawal nupur202000@gmail.com

applied bootstrap grid structure on settings page.
Signed-off-by: Nupur Agrawal <nupur202000@gmail.com>

@mauriciofauth mauriciofauth changed the base branch from master to gsoc-bootstrap Jun 10, 2019

Added grid structure to databases page
Signed-off-by: Nupur Agrawal <nupur202000@gmail.com>
@codecov

This comment has been minimized.

Copy link

commented Jun 16, 2019

Codecov Report

Merging #15320 into gsoc-bootstrap will not change coverage.
The diff coverage is n/a.

@@                Coverage Diff                @@
##             gsoc-bootstrap   #15320   +/-   ##
=================================================
  Coverage             52.75%   52.75%           
  Complexity            14071    14071           
=================================================
  Files                   484      484           
  Lines                 62212    62212           
=================================================
  Hits                  32823    32823           
  Misses                29389    29389

murex971 added some commits Jun 16, 2019

Grid structure added to import,export,charset,engine,replication page
Signed-off-by: Nupur Agrawal <nupur202000@gmail.com>
@phpmyadmin-bot

This comment has been minimized.

Copy link

commented on 9c63aba Jun 17, 2019

This commit contains trailing whitespace, what is prohibited in phpMyAdmin. Please check our Developer guidelines for more information.

Offending files: templates/server/replication/index.twig

murex971 added some commits Jun 17, 2019

Lint fxes
Signed-off-by: Nupur Agrawal <nupur202000@gmail.com>
Grid implemented on status pages.
Signed-off-by: Nupur Agrawal <nupur202000@gmail.com>
@phpmyadmin-bot

This comment has been minimized.

Copy link

commented on 4eeec63 Jun 21, 2019

This commit contains trailing whitespace, what is prohibited in phpMyAdmin. Please check our Developer guidelines for more information.

Offending files: templates/server/status/base.twig, templates/server/status/queries/index.twig

murex971 added some commits Jun 21, 2019

Grid completed on settings pages.
Signed-off-by: Nupur Agrawal <nupur202000@gmail.com>
Grid structure edits
Signed-off-by: Nupur Agrawal <nupur202000@gmail.com>
'items' => $items,
]);
$htmlOutput .= '<br>';
$htmlOutput .= '<div class="tabs_contents">';
// $htmlOutput .= '<br>';

This comment has been minimized.

Copy link
@mauriciofauth

mauriciofauth Jul 2, 2019

Member

You forgot a commented line here.

Dealt with requested changes
Signed-off-by: Nupur Agrawal <nupur202000@gmail.com>

@mauriciofauth mauriciofauth self-assigned this Jul 2, 2019


<div id="div_mysql_charset_collations">
<div class="row">

This comment has been minimized.

Copy link
@mauriciofauth

mauriciofauth Jul 7, 2019

Member

Did you intentionally removed the div id attribute?

@@ -30,3 +33,4 @@
{% endfor %}
</table>
</div>
</div>

This comment has been minimized.

Copy link
@mauriciofauth

mauriciofauth Jul 7, 2019

Member

Add a blank line at the end of the file.

Some fixes on charset page.
Signed-off-by: Nupur Agrawal <nupur202000@gmail.com>

@mauriciofauth mauriciofauth changed the base branch from gsoc-bootstrap to master Jul 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.