Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

applied bootstrap grid structure on settings page. #15320

Merged
merged 11 commits into from Jul 20, 2019

Conversation

murex971
Copy link
Contributor

Signed-off-by: Nupur Agrawal nupur202000@gmail.com

Signed-off-by: Nupur Agrawal <nupur202000@gmail.com>
@MauricioFauth MauricioFauth changed the base branch from master to gsoc-bootstrap June 10, 2019 14:33
Signed-off-by: Nupur Agrawal <nupur202000@gmail.com>
@codecov
Copy link

codecov bot commented Jun 16, 2019

Codecov Report

Merging #15320 into master will decrease coverage by 0.23%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master   #15320      +/-   ##
============================================
- Coverage     52.99%   52.75%   -0.24%     
- Complexity    14010    14071      +61     
============================================
  Files           482      484       +2     
  Lines         61987    62212     +225     
============================================
- Hits          32853    32823      -30     
- Misses        29134    29389     +255

murex971 and others added 6 commits June 16, 2019 17:39
Signed-off-by: Nupur Agrawal <nupur202000@gmail.com>
Signed-off-by: Nupur Agrawal <nupur202000@gmail.com>
Signed-off-by: Nupur Agrawal <nupur202000@gmail.com>
Signed-off-by: Nupur Agrawal <nupur202000@gmail.com>
Signed-off-by: Nupur Agrawal <nupur202000@gmail.com>
'items' => $items,
]);
$htmlOutput .= '<br>';
$htmlOutput .= '<div class="tabs_contents">';
// $htmlOutput .= '<br>';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You forgot a commented line here.

Signed-off-by: Nupur Agrawal <nupur202000@gmail.com>
@MauricioFauth MauricioFauth self-assigned this Jul 2, 2019

<div id="div_mysql_charset_collations">
<div class="row">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you intentionally removed the div id attribute?

@@ -30,3 +33,4 @@
{% endfor %}
</table>
</div>
</div>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a blank line at the end of the file.

Signed-off-by: Nupur Agrawal <nupur202000@gmail.com>
@MauricioFauth MauricioFauth changed the base branch from gsoc-bootstrap to master July 12, 2019 06:17
@MauricioFauth MauricioFauth merged commit 4362ba0 into phpmyadmin:master Jul 20, 2019
@MauricioFauth
Copy link
Member

Merged, thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants