Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring and Improving page.js of designer #15339

Open
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
6 participants
@Bournvita1998
Copy link
Contributor

commented Jun 17, 2019

Signed-off-by: Bournvita1998 mohit.kuri@research.iiit.ac.in

Description

Refactored and Improved page.js of the designer section.

Fixes #

Before submitting pull request, please review the following checklist:

  • Make sure you have read our CONTRIBUTING.md document.
  • Make sure you are making a pull request against the correct branch. For example, for bug fixes in a released version use the corresponding QA branch and for new features use the master branch. If you have a doubt, you can ask as a comment in the bug report or on the mailing list.
  • Every commit has proper Signed-off-by line as described in our DCO. This ensures that the work you're submitting is your own creation.
  • Every commit has a descriptive commit message.
  • Every commit is needed on its own, if you have just minor fixes to previous commits, you can squash them.
  • Any new functionality is covered by tests.
Refactoring and Improving page.js of designer
Signed-off-by: Bournvita1998 <mohit.kuri@research.iiit.ac.in>
@ibennetch

This comment has been minimized.

Copy link
Member

commented Jun 22, 2019

Could you please use your real name in the signoff message? You can modify this with git commit --amend and push back to your repository (it might require a force-push, which is okay).

@devenbansod
Copy link
Member

left a comment

Please make sure you test your changes (ideally even before you commit, but definitely before you submit the PR)

var input = allTables[tab];
if (input.value) {
var element = document.getElementById(input.value);
var element = $('#' + input.value);

This comment has been minimized.

Copy link
@devenbansod

devenbansod Jul 7, 2019

Member

@Bournvita1998 even this won't work, as we discussed in #15338

var tbId = db + '.' + tblCords[t].tableName;
var table = document.getElementById(tbId);
var table = $('#' + tbId);

This comment has been minimized.

Copy link
@devenbansod
table.style.top = tblCords[t].y + 'px';
table.style.left = tblCords[t].x + 'px';

var checkbox = document.getElementById('check_vis_' + tbId);
var checkbox = $('#check_vis_' + tbId);

This comment has been minimized.

Copy link
@devenbansod
Removing hard-coded things from page.js of the designer
Signed-off-by: Mohit Kuri <mohit.kuri@research.iiit.ac.in>
@phpmyadmin-bot

This comment has been minimized.

Copy link

commented on c34a1fa Jul 10, 2019

This commit has an invalid Signed-Off-By line, please use your full name for legal compliance reasons.
Please check Developer's Certificate of Origin
Here is a valid example: Signed-off-by: Jane Smith <jane.smith@example.org>

@codecov

This comment has been minimized.

Copy link

commented Jul 10, 2019

Codecov Report

Merging #15339 into gsoc-db-designer will not change coverage.
The diff coverage is n/a.

@@                 Coverage Diff                 @@
##             gsoc-db-designer   #15339   +/-   ##
===================================================
  Coverage               52.72%   52.72%           
  Complexity              14071    14071           
===================================================
  Files                     484      484           
  Lines                   62131    62131           
===================================================
  Hits                    32760    32760           
  Misses                  29371    29371

@mauriciofauth mauriciofauth changed the base branch from gsoc-db-designer to master Jul 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.