Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improving move.js of Designer #15345

Open
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
5 participants
@Bournvita1998
Copy link
Contributor

commented Jun 20, 2019

Signed-off-by: Mohit Kuri mohit.kuri@research.iiit.ac.in

Description

Improved the performance of move.js in the designer section

Fixes #

Before submitting pull request, please review the following checklist:

  • Make sure you have read our CONTRIBUTING.md document.
  • Make sure you are making a pull request against the correct branch. For example, for bug fixes in a released version use the corresponding QA branch and for new features use the master branch. If you have a doubt, you can ask as a comment in the bug report or on the mailing list.
  • Every commit has proper Signed-off-by line as described in our DCO. This ensures that the work you're submitting is your own creation.
  • Every commit has a descriptive commit message.
  • Every commit is needed on its own, if you have just minor fixes to previous commits, you can squash them.
  • Any new functionality is covered by tests.
Improving move.js of Designer
Signed-off-by: Bournvita1998 <mohit.kuri@research.iiit.ac.in>
@phpmyadmin-bot

This comment has been minimized.

Copy link

commented on c245a28 Jun 20, 2019

This commit has an invalid Signed-Off-By line, please use your full name for legal compliance reasons.
Please check Developer's Certificate of Origin
Here is a valid example: Signed-off-by: Jane Smith <jane.smith@example.org>

@williamdes
Copy link
Member

left a comment

@Bournvita1998 please fix the DCO signature :)

@mauriciofauth mauriciofauth changed the base branch from gsoc-db-designer to master Jul 12, 2019

@devenbansod
Copy link
Member

left a comment

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.