New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a request router #15377
Merged
Merged
Add a request router #15377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
williamdes
approved these changes
Jul 7, 2019
Codecov Report
@@ Coverage Diff @@
## master #15377 +/- ##
============================================
- Coverage 52.99% 52.98% -0.02%
Complexity 14047 14047
============================================
Files 481 481
Lines 62011 62027 +16
============================================
Hits 32862 32862
- Misses 29149 29165 +16 |
Codecov Report
@@ Coverage Diff @@
## master #15377 +/- ##
============================================
- Coverage 52.99% 52.97% -0.02%
- Complexity 14047 14051 +4
============================================
Files 481 482 +1
Lines 62011 62043 +32
============================================
+ Hits 32862 32867 +5
- Misses 29149 29176 +27 |
williamdes
approved these changes
Jul 8, 2019
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
Uses the router instead Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
williamdes
approved these changes
Jul 10, 2019
MauricioFauth
added a commit
to MauricioFauth/phpmyadmin
that referenced
this pull request
Jul 13, 2019
Add a request router [ci skip] Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces a router to help with the request management.
For example, we can use
http://localhost/index.php?route=/server/databasesinstead of usehttp://localhost/server_databases.php.The objective is to reduce the number of entry points and to use the
index.phpas a front controller redirecting all the requests to it.The idea of using the
routeparameter is to help with the transition, as it does not require URL rewriting, however, once the transition is complete, it will be possible to use URL rewrite to have pretty URLs like:http://localhost/server/databases.Other objective is to fix the issue that happens when opening some links in a new window, by creating unique routes without the problem of having an SQL query in the URL.
For now, it only maps 1:1 the entry points with the routes.
For example:
/server/databases => server_databases.phpOnce this is done, the next step will be to improve the routes by refactoring the
libraries/entry_pointsfiles and adding more routes.