Refactoring move.js of Designer

[Bournvita1998]

Signed-off-by: Mohit Kuri mohit.kuri@research.iiit.ac.in

Description

Refactored move.js of the designer.

Fixes #

Before submitting pull request, please review the following checklist:

• Make sure you have read our CONTRIBUTING.md document.
• Make sure you are making a pull request against the correct branch. For example, for bug fixes in a released version use the corresponding QA branch and for new features use the master branch. If you have a doubt, you can ask as a comment in the bug report or on the mailing list.
• Every commit has proper Signed-off-by line as described in our DCO. This ensures that the work you're submitting is your own creation.
• Every commit has a descriptive commit message.
• Every commit is needed on its own, if you have just minor fixes to previous commits, you can squash them.
• Any new functionality is covered by tests.

[Bournvita1998]

For testing, I have tested this whole thing in general. Here is an example of the same:

Using - document.getElementById('selector')

Using - $('#selector')[0]

Since this worked, I replicated the same here.

@devenbansod Please review and provide feedback for the same. Will proceed further once the work till here is approved and we are good to go ahead.

[devenbansod]

@Bournvita1998 I've left a comment. It applies to all the changes.

[devenbansod]

@Bournvita1998 this would work for the elements selected with IDs only. I'd ideally use .css() method to set the styles instead of manually selecting the first element and setting the native properties. IMO (even though it works) this current approach sort of doesn't use JQuery's power at all.

Using .css() would auto-loop over all the selected elements, so would be easier to read when we're selecting based on input types, classes etc.

[shucon]

I agree with @devenbansod . Don't try to hard-code things. As you're trying to refactor the code, try to do it in such a way that would let other developers work on the code without much changes to your code. It gets extremely difficult to manage such things on such a large scale.

[Bournvita1998]

Okay, I will make these changes asap. Thanks @devenbansod, @shucon

[codecov]

Codecov Report

Merging #15378 into master will decrease coverage by 0.26%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master   #15378      +/-   ##
============================================
- Coverage     52.99%   52.72%   -0.27%     
- Complexity    14047    14071      +24     
============================================
  Files           481      484       +3     
  Lines         62011    62131     +120     
============================================
- Hits          32862    32760     -102     
- Misses        29149    29371     +222

[Bournvita1998]

@devenbansod @shucon Please have a look now

[Bournvita1998]

I am done refactoring move.js once. Please share your reviews so that I can make the possible changes

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.