Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed hard-coded things from init.js of the designer #15382

Open
wants to merge 1 commit into
base: master
from

Conversation

@Bournvita1998
Copy link
Contributor

commented Jul 10, 2019

Signed-off-by: Mohit Kuri mohit.kuri@research.iiit.ac.in

Description

Resolves issues exiting in #15338

Fixes #

Before submitting pull request, please review the following checklist:

  • Make sure you have read our CONTRIBUTING.md document.
  • Make sure you are making a pull request against the correct branch. For example, for bug fixes in a released version use the corresponding QA branch and for new features use the master branch. If you have a doubt, you can ask as a comment in the bug report or on the mailing list.
  • Every commit has proper Signed-off-by line as described in our DCO. This ensures that the work you're submitting is your own creation.
  • Every commit has a descriptive commit message.
  • Every commit is needed on its own, if you have just minor fixes to previous commits, you can squash them.
  • Any new functionality is covered by tests.
removed hard-coded things
Signed-off-by: Mohit Kuri <mohit.kuri@research.iiit.ac.in>

@Bournvita1998 Bournvita1998 changed the title removed hard-coded things Removed hard-coded things from init.js of the designer Jul 10, 2019

@mauriciofauth mauriciofauth changed the base branch from gsoc-db-designer to master Jul 12, 2019

@williamdes williamdes added this to To do in pull-requests Aug 20, 2019

@williamdes williamdes moved this from To do to GSOC in pull-requests Aug 20, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
You can’t perform that action at this time.