Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed hard-coded things from init.js of the designer #15382

Closed
wants to merge 1 commit into from

Conversation

@Bournvita1998
Copy link
Contributor

@Bournvita1998 Bournvita1998 commented Jul 10, 2019

Signed-off-by: Mohit Kuri mohit.kuri@research.iiit.ac.in

Description

Resolves issues exiting in #15338

Fixes #

Before submitting pull request, please review the following checklist:

  • Make sure you have read our CONTRIBUTING.md document.
  • Make sure you are making a pull request against the correct branch. For example, for bug fixes in a released version use the corresponding QA branch and for new features use the master branch. If you have a doubt, you can ask as a comment in the bug report or on the mailing list.
  • Every commit has proper Signed-off-by line as described in our DCO. This ensures that the work you're submitting is your own creation.
  • Every commit has a descriptive commit message.
  • Every commit is needed on its own, if you have just minor fixes to previous commits, you can squash them.
  • Any new functionality is covered by tests.
Signed-off-by: Mohit Kuri <mohit.kuri@research.iiit.ac.in>
@Bournvita1998 Bournvita1998 changed the title removed hard-coded things Removed hard-coded things from init.js of the designer Jul 10, 2019
@mauriciofauth mauriciofauth changed the base branch from gsoc-db-designer to master Jul 12, 2019
@williamdes williamdes added this to To do in pull-requests Aug 20, 2019
@williamdes williamdes moved this from To do to GSOC in pull-requests Aug 20, 2019
@@ -54,22 +54,22 @@ AJAX.registerOnload('designer/init.js', function () {
}

$('#query_Aggregate_Button').on('click', function () {
$('#query_Aggregate').style.display = 'none';
$('#query_Aggregate').css("display", 'none');
Copy link
Member

@mauriciofauth mauriciofauth Sep 11, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
$('#query_Aggregate').css("display", 'none');
$('#query_Aggregate').css('display', 'none');

Loading

});

$('#query_having_button').on('click', function () {
$('#query_having').style.display = 'none';
$('#query_having').css("display", 'none');
Copy link
Member

@mauriciofauth mauriciofauth Sep 11, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
$('#query_having').css("display", 'none');
$('#query_having').css('display', 'none');

Loading

});

$('#query_rename_to_button').on('click', function () {
$('#query_rename_to').style.display = 'none';
$('#query_rename_to').css("display", 'none');
Copy link
Member

@mauriciofauth mauriciofauth Sep 11, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
$('#query_rename_to').css("display", 'none');
$('#query_rename_to').css('display', 'none');

Loading

});

$('#build_query_button').on('click', function () {
DesignerHistory.buildQuery('SQL Query on Database', 0);
});

$('#query_where_button').on('click', function () {
$('#query_where').style.display = 'none';
$('#query_where').css("display", 'none');
Copy link
Member

@mauriciofauth mauriciofauth Sep 11, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
$('#query_where').css("display", 'none');
$('#query_where').css('display', 'none');

Loading

pull-requests automation moved this from GSOC to Review in progress Sep 11, 2019
@stale
Copy link

@stale stale bot commented Nov 10, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

Loading

@stale stale bot added the wontfix label Nov 10, 2019
@stale stale bot closed this Nov 17, 2019
pull-requests automation moved this from Review in progress to Done Nov 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
pull-requests
  
Done
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants