Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bootstrap table classes added to all tables #15392

Open
wants to merge 14 commits into
base: master
from

Conversation

@murex971
Copy link
Contributor

commented Jul 18, 2019

Signed-off-by: Nupur Agrawal nupur202000@gmail.com

Description

Applies bootsrap table classes to all the tables and provide an overall consistency across tables.

Before submitting pull request, please review the following checklist:

  • Make sure you have read our CONTRIBUTING.md document.
  • Make sure you are making a pull request against the correct branch. For example, for bug fixes in a released version use the corresponding QA branch and for new features use the master branch. If you have a doubt, you can ask as a comment in the bug report or on the mailing list.
  • Every commit has proper Signed-off-by line as described in our DCO. This ensures that the work you're submitting is your own creation.
  • Every commit has a descriptive commit message.
  • Every commit is needed on its own, if you have just minor fixes to previous commits, you can squash them.
  • Any new functionality is covered by tests.

murex971 added some commits Jun 1, 2019

first commit
Signed-off-by: Nupur Agrawal <nupur202000@gmail.com>
bootstrap table classes added to all classes
Signed-off-by: Nupur Agrawal <nupur202000@gmail.com>
@phpmyadmin-bot

This comment has been minimized.

Copy link

commented on e72e632 Jul 18, 2019

This commit contains trailing whitespace, what is prohibited in phpMyAdmin. Please check our Developer guidelines for more information.

Offending files: templates/server/plugins/index.twig, themes/pmahomme/scss/_common.scss

Merge branch 'master' of github.com:murex971/phpmyadmin into tables-i…
…mplementation

Signed-off-by: Nupur Agrawal <nupur202000@gmail.com>
@phpmyadmin-bot

This comment has been minimized.

Copy link

commented on 8994c48 Jul 18, 2019

This commit contains trailing whitespace, what is prohibited in phpMyAdmin. Please check our Developer guidelines for more information.

Offending files: templates/home/index.twig

murex971 added some commits Jul 18, 2019

@murex971 murex971 changed the title bootstrap table classes added to all classes bootstrap table classes added to all tables Jul 19, 2019

murex971 added some commits Jul 19, 2019

table fixes on settings page
Signed-off-by: Nupur Agrawal <nupur202000@gmail.com>

@mauriciofauth mauriciofauth self-assigned this Jul 20, 2019

@mauriciofauth

This comment has been minimized.

Copy link
Member

commented Jul 20, 2019

@sudo-bot Deploy PR

@sudo-bot

This comment has been minimized.

Copy link

commented Jul 20, 2019

Deployed (phpmyadmin-pr-15392): tables-implementation commit: 7f37ef0e37482992f7b510d284227b408d57f34d

url: https://phpmyadmin-pr-15392.wdes.eu.org
user: public
user: public


Deploy finished

1 similar comment
@sudo-bot

This comment has been minimized.

Copy link

commented Jul 20, 2019

Deployed (phpmyadmin-pr-15392): tables-implementation commit: 7f37ef0e37482992f7b510d284227b408d57f34d

url: https://phpmyadmin-pr-15392.wdes.eu.org
user: public
user: public


Deploy finished

@mauriciofauth

This comment has been minimized.

Copy link
Member

commented Jul 20, 2019

Applies bootsrap table classes to all the tables and provide an overall consistency across tables.

@murex971 You commented that you added the Bootstrap classes in all the tables, but only the tables of the server pages received the classes, the database pages and the table pages are still missing. Is this pull request a work in progress?

@murex971

This comment has been minimized.

Copy link
Contributor Author

commented Jul 22, 2019

Applies bootsrap table classes to all the tables and provide an overall consistency across tables.

@murex971 You commented that you added the Bootstrap classes in all the tables, but only the tables of the server pages received the classes, the database pages and the table pages are still missing. Is this pull request a work in progress?

yeah, it is still in progress.

murex971 added some commits Jul 22, 2019

first commit
Signed-off-by: Nupur Agrawal <nupur202000@gmail.com>
bootstrap table classes added to all classes
Signed-off-by: Nupur Agrawal <nupur202000@gmail.com>
@phpmyadmin-bot

This comment has been minimized.

Copy link

commented on f8b6524 Jul 27, 2019

This commit contains trailing whitespace, what is prohibited in phpMyAdmin. Please check our Developer guidelines for more information.

Offending files: themes/pmahomme/scss/_common.scss

@williamdes williamdes added this to To do in pull-requests Aug 20, 2019

@williamdes williamdes moved this from To do to GSOC in pull-requests Aug 20, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
You can’t perform that action at this time.