Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bootstrap table classes added to all tables #15392

Closed
wants to merge 16 commits into from

Conversation

@murex971
Copy link
Contributor

@murex971 murex971 commented Jul 18, 2019

Signed-off-by: Nupur Agrawal nupur202000@gmail.com

Description

Applies bootsrap table classes to all the tables and provide an overall consistency across tables.

Before submitting pull request, please review the following checklist:

  • Make sure you have read our CONTRIBUTING.md document.
  • Make sure you are making a pull request against the correct branch. For example, for bug fixes in a released version use the corresponding QA branch and for new features use the master branch. If you have a doubt, you can ask as a comment in the bug report or on the mailing list.
  • Every commit has proper Signed-off-by line as described in our DCO. This ensures that the work you're submitting is your own creation.
  • Every commit has a descriptive commit message.
  • Every commit is needed on its own, if you have just minor fixes to previous commits, you can squash them.
  • Any new functionality is covered by tests.
murex971 added 2 commits Jun 8, 2019
Signed-off-by: Nupur Agrawal <nupur202000@gmail.com>
Signed-off-by: Nupur Agrawal <nupur202000@gmail.com>
…mplementation

Signed-off-by: Nupur Agrawal <nupur202000@gmail.com>
@murex971 murex971 changed the title bootstrap table classes added to all classes bootstrap table classes added to all tables Jul 19, 2019
murex971 added 2 commits Jul 19, 2019
Signed-off-by: Nupur Agrawal <nupur202000@gmail.com>
@mauriciofauth mauriciofauth self-assigned this Jul 20, 2019
@mauriciofauth
Copy link
Member

@mauriciofauth mauriciofauth commented Jul 20, 2019

@sudo-bot Deploy PR

@sudo-robot
Copy link

@sudo-robot sudo-robot commented Jul 20, 2019

Deployed (phpmyadmin-pr-15392): tables-implementation commit: 7f37ef0e37482992f7b510d284227b408d57f34d

url: https://phpmyadmin-pr-15392.wdes.eu.org
user: public
user: public


Deploy finished

1 similar comment
@sudo-robot
Copy link

@sudo-robot sudo-robot commented Jul 20, 2019

Deployed (phpmyadmin-pr-15392): tables-implementation commit: 7f37ef0e37482992f7b510d284227b408d57f34d

url: https://phpmyadmin-pr-15392.wdes.eu.org
user: public
user: public


Deploy finished

@mauriciofauth
Copy link
Member

@mauriciofauth mauriciofauth commented Jul 20, 2019

Applies bootsrap table classes to all the tables and provide an overall consistency across tables.

@murex971 You commented that you added the Bootstrap classes in all the tables, but only the tables of the server pages received the classes, the database pages and the table pages are still missing. Is this pull request a work in progress?

@murex971
Copy link
Contributor Author

@murex971 murex971 commented Jul 22, 2019

Applies bootsrap table classes to all the tables and provide an overall consistency across tables.

@murex971 You commented that you added the Bootstrap classes in all the tables, but only the tables of the server pages received the classes, the database pages and the table pages are still missing. Is this pull request a work in progress?

yeah, it is still in progress.

@williamdes williamdes added this to To do in pull-requests Aug 20, 2019
@williamdes williamdes moved this from To do to GSOC in pull-requests Aug 20, 2019
templates/server/plugins/index.twig Outdated Show resolved Hide resolved
templates/server/plugins/index.twig Outdated Show resolved Hide resolved
templates/server/plugins/index.twig Outdated Show resolved Hide resolved
templates/server/plugins/index.twig Outdated Show resolved Hide resolved
templates/server/plugins/index.twig Outdated Show resolved Hide resolved
templates/server/plugins/index.twig Outdated Show resolved Hide resolved
templates/server/plugins/index.twig Outdated Show resolved Hide resolved
templates/server/plugins/index.twig Outdated Show resolved Hide resolved
templates/server/plugins/index.twig Outdated Show resolved Hide resolved
templates/server/plugins/index.twig Outdated Show resolved Hide resolved
pull-requests automation moved this from GSOC to Review in progress Aug 21, 2019
Co-Authored-By: Maurício Meneghini Fauth <mauricio@fauth.dev>
@stale
Copy link

@stale stale bot commented Oct 21, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Oct 21, 2019
@stale stale bot closed this Oct 28, 2019
pull-requests automation moved this from Review in progress to Done Oct 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
pull-requests
  
Done
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants