Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Form classes added #15400

Closed
wants to merge 5 commits into from
Closed

Conversation

@murex971
Copy link
Contributor

@murex971 murex971 commented Jul 26, 2019

Description

Addresses different classes associated with forms.

Before submitting pull request, please review the following checklist:

  • Make sure you have read our CONTRIBUTING.md document.
  • Make sure you are making a pull request against the correct branch. For example, for bug fixes in a released version use the corresponding QA branch and for new features use the master branch. If you have a doubt, you can ask as a comment in the bug report or on the mailing list.
  • Every commit has proper Signed-off-by line as described in our DCO. This ensures that the work you're submitting is your own creation.
  • Every commit has a descriptive commit message.
  • Every commit is needed on its own, if you have just minor fixes to previous commits, you can squash them.
  • Any new functionality is covered by tests.
murex971 and others added 2 commits Jul 26, 2019
Signed-off-by: Nupur Agrawal <nupur202000@gmail.com>
@@ -380,19 +380,19 @@ fieldset {
}

legend {
font-weight: bold;
font-weight: bold !important;
Copy link
Member

@mauriciofauth mauriciofauth Jul 31, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is not recommended to add !important. It is possible to do it in another way?

Copy link
Contributor Author

@murex971 murex971 Aug 5, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was the most easy and efficient way to do that thing. As the bootstrap class was overwriting all the css styles, some of which were required as they were, so I added important with them.

murex971 added 2 commits Aug 3, 2019
Signed-off-by: Nupur Agrawal <nupur202000@gmail.com>
@williamdes williamdes added this to To do in pull-requests Aug 20, 2019
@williamdes williamdes moved this from To do to GSOC in pull-requests Aug 20, 2019
@mauriciofauth mauriciofauth self-assigned this Aug 21, 2019
@stale
Copy link

@stale stale bot commented Oct 21, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Oct 21, 2019
@stale stale bot closed this Oct 28, 2019
pull-requests automation moved this from GSOC to Done Oct 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
pull-requests
  
Done
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants