New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix PHP 7.4 deprecation: array/string curly braces access #15404
Fix PHP 7.4 deprecation: array/string curly braces access #15404
Conversation
753f8d3
to
16e8b5e
Compare
Yes. You can target QA_4_9 and then we merge it to the others branches. |
|
This pull requests contains too many commits, in most cases it is caused by wrong merge target. In case you have forked |
Deprecated: Array and string offset access syntax with curly braces is deprecated https://github.com/php/php-src/blob/0e6e2297fcb27103cc5d550ee8434680ff1e879e/UPGRADING#L356-L357 Signed-off-by: Jack Cherng <jfcherng@gmail.com>
16e8b5e
to
b989e82
Compare
Codecov Report
@@ Coverage Diff @@
## QA_4_9 #15404 +/- ##
============================================
- Coverage 55.57% 53.01% -2.57%
+ Complexity 14510 14029 -481
============================================
Files 494 482 -12
Lines 71101 62052 -9049
============================================
- Hits 39517 32897 -6620
+ Misses 31584 29155 -2429 |
Codecov Report
@@ Coverage Diff @@
## QA_4_9 #15404 +/- ##
=========================================
Coverage 55.57% 55.57%
Complexity 14510 14510
=========================================
Files 494 494
Lines 71101 71101
=========================================
Hits 39517 39517
Misses 31584 31584 |
|
Rebased to QA_4_9. |
|
Merged, thanks for your contribution! |
[ci skip] Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
|
Great, thanks for this! |
Deprecated: Array and string offset access syntax with curly braces is deprecated
Hopefully these are all (or most) of them:
https://github.com/php/php-src/blob/0e6e2297fcb27103cc5d550ee8434680ff1e879e/UPGRADING#L356-L357
Also apply to the QA_4_9 branch?