Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PHP 7.4 deprecation: array/string curly braces access #15404

Merged
merged 1 commit into from Jul 30, 2019

Conversation

jfcherng
Copy link
Contributor

@jfcherng jfcherng commented Jul 26, 2019

Deprecated: Array and string offset access syntax with curly braces is deprecated

Hopefully these are all (or most) of them:

[Clover@Clover-NB phpmyadmin](master)$ rg "(\\$|->|::)[A-Za-z0-9_]+\{"
libraries\replication.inc.php:125:// set $server_{master/slave}_status and assign values
libraries\classes\Url.php:253:                $separator = $arg_separator{0};
libraries\classes\Server\Privileges.php:4014:                if ($sql_query{0} != '#') {
libraries\classes\Server\Privileges.php:4269:            if ($sql_query{0} != '#') {

https://github.com/php/php-src/blob/0e6e2297fcb27103cc5d550ee8434680ff1e879e/UPGRADING#L356-L357


Also apply to the QA_4_9 branch?

@MauricioFauth
Copy link
Member

Also apply to the QA_4_9 branch?

Yes. You can target QA_4_9 and then we merge it to the others branches.

@jfcherng jfcherng changed the base branch from master to QA_4_9 July 27, 2019 00:31
@phpmyadmin-bot
Copy link
Contributor

This pull requests contains too many commits, in most cases it is caused by wrong merge target. In case you have forked master branch you should also ask merging to master branch. See GitHub documentation for more details.

Deprecated: Array and string offset access syntax with curly braces is deprecated

https://github.com/php/php-src/blob/0e6e2297fcb27103cc5d550ee8434680ff1e879e/UPGRADING#L356-L357

Signed-off-by: Jack Cherng <jfcherng@gmail.com>
@codecov
Copy link

codecov bot commented Jul 27, 2019

Codecov Report

Merging #15404 into QA_4_9 will decrease coverage by 2.56%.
The diff coverage is 3.82%.

@@             Coverage Diff              @@
##             QA_4_9   #15404      +/-   ##
============================================
- Coverage     55.57%   53.01%   -2.57%     
+ Complexity    14510    14029     -481     
============================================
  Files           494      482      -12     
  Lines         71101    62052    -9049     
============================================
- Hits          39517    32897    -6620     
+ Misses        31584    29155    -2429

@codecov
Copy link

codecov bot commented Jul 27, 2019

Codecov Report

Merging #15404 into QA_4_9 will not change coverage.
The diff coverage is 66.66%.

@@            Coverage Diff            @@
##             QA_4_9   #15404   +/-   ##
=========================================
  Coverage     55.57%   55.57%           
  Complexity    14510    14510           
=========================================
  Files           494      494           
  Lines         71101    71101           
=========================================
  Hits          39517    39517           
  Misses        31584    31584

@jfcherng
Copy link
Contributor Author

Rebased to QA_4_9.

@MauricioFauth MauricioFauth merged commit a0c4786 into phpmyadmin:QA_4_9 Jul 30, 2019
@MauricioFauth
Copy link
Member

Merged, thanks for your contribution!

@MauricioFauth MauricioFauth self-assigned this Jul 30, 2019
@jfcherng jfcherng deleted the fix-php74-curly-braces branch July 30, 2019 00:39
MauricioFauth added a commit that referenced this pull request Jul 30, 2019
[ci skip]

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
@ibennetch
Copy link
Member

Great, thanks for this!

@williamdes williamdes added this to the 4.9.1 milestone Dec 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants