Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Designer saves page successfully even if dB name has period. #15438

Closed
wants to merge 1 commit into from

Conversation

@Bournvita1998
Copy link
Contributor

@Bournvita1998 Bournvita1998 commented Aug 17, 2019

Signed-off-by: Mohit Kuri mohit.kuri@research.iiit.ac.in

Description

Designer pages will now be successfully saved even if it has period.

Fixes #14945

Before submitting pull request, please review the following checklist:

  • Make sure you have read our CONTRIBUTING.md document.
  • Make sure you are making a pull request against the correct branch. For example, for bug fixes in a released version use the corresponding QA branch and for new features use the master branch. If you have a doubt, you can ask as a comment in the bug report or on the mailing list.
  • Every commit has proper Signed-off-by line as described in our DCO. This ensures that the work you're submitting is your own creation.
  • Every commit has a descriptive commit message.
  • Every commit is needed on its own, if you have just minor fixes to previous commits, you can squash them.
  • Any new functionality is covered by tests.
Signed-off-by: Mohit Kuri <mohit.kuri@research.iiit.ac.in>
@shucon
Copy link
Contributor

@shucon shucon commented Aug 18, 2019

@sudo-bot Deploy PR

Loading

@sudo-robot
Copy link

@sudo-robot sudo-robot commented Aug 18, 2019

Deployed (phpmyadmin-pr-15438): DB_Period commit: eae9cc1b327677b71cad3bcf349b67d9a1405620

url: https://phpmyadmin-pr-15438.wdes.eu.org
user: public
user: public


Deploy finished

Loading

@shucon
Copy link
Contributor

@shucon shucon commented Aug 19, 2019

Loading

@williamdes williamdes added this to To do in pull-requests Aug 20, 2019
@williamdes williamdes moved this from To do to blocked in pull-requests Aug 20, 2019
@williamdes williamdes self-assigned this Aug 22, 2019
pull-requests automation moved this from blocked to Done Aug 23, 2019
@williamdes
Copy link
Member

@williamdes williamdes commented Aug 23, 2019

@Bournvita1998 thanks for trying to help, I fixed the issue with a23f2ba

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
pull-requests
  
Done
Linked issues

Successfully merging this pull request may close these issues.

4 participants