Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Saves tables of other databases in the page of the designer section #15458

Closed

Conversation

@Bournvita1998
Copy link
Contributor

@Bournvita1998 Bournvita1998 commented Aug 25, 2019

Description

It doesn't completely fix #13587 but it stores all the relevant data to the phpmyadmin's pma__pdf_pages and pma__table_coords. Here are the screenshots in the order for understanding.

Initially:
Selection_087

Add a table:
Selection_088

Table added:
Selection_089

Save as
Selection_090

Saved
Selection_091

Open page
Selection_092

db = a(main database)
Selection_093

db = COLLEGE(database of the added table)
Selection_094

pma__pdf_pages
Selection_095

pma__table_coords
Selection_096

TODO left here:
When we click "open page" it should not just retrieve data the given database but what it should do is use the page number(not the database name) as displayed in the pma__table_coords associated with the given page name and database(main database).
Need to look at this and make changes accordingly.

Fixes #13587

Before submitting pull request, please review the following checklist:

  • Make sure you have read our CONTRIBUTING.md document.
  • Make sure you are making a pull request against the correct branch. For example, for bug fixes in a released version use the corresponding QA branch and for new features use the master branch. If you have a doubt, you can ask as a comment in the bug report or on the mailing list.
  • Every commit has proper Signed-off-by line as described in our DCO. This ensures that the work you're submitting is your own creation.
  • Every commit has a descriptive commit message.
  • Every commit is needed on its own, if you have just minor fixes to previous commits, you can squash them.
  • Any new functionality is covered by tests.
Signed-off-by: Mohit Kuri <mohit.kuri@research.iiit.ac.in>
Signed-off-by: Mohit Kuri <mohit.kuri@research.iiit.ac.in>
@williamdes
Copy link
Member

@williamdes williamdes commented Aug 25, 2019

@Bournvita1998 can you please rebase onto the latest QA_4_9?
The code you modified does not exist anymore
Please use QA_4_9 as base and target

Thanks :)

Loading

@williamdes
Copy link
Member

@williamdes williamdes commented Aug 25, 2019

And I know you can not say for sure that it did not fix the issue since the headers are not blue in the designer
I fixed them in the latest changes :)

Or you forgot to run npm run css-compile

Loading

@williamdes williamdes added this to In progress in pull-requests via automation Aug 28, 2019
@williamdes williamdes moved this from In progress to blocked in pull-requests Aug 28, 2019
@stale
Copy link

@stale stale bot commented Nov 23, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

Loading

@stale stale bot added the wontfix label Nov 23, 2019
@stale stale bot closed this Nov 30, 2019
pull-requests automation moved this from blocked to Done Nov 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
pull-requests
  
Done
Linked issues

Successfully merging this pull request may close these issues.

3 participants