Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Sort By Key issue #15475 #15537

Merged
merged 1 commit into from Oct 30, 2019
Merged

Fix Sort By Key issue #15475 #15537

merged 1 commit into from Oct 30, 2019

Conversation

vmedvedev
Copy link

@vmedvedev vmedvedev commented Oct 28, 2019 •
edited by williamdes

Signed-off-by: Vitalii Medvediev vitaliim@onehourtranslation.com

Description

PR to fix issue #15475 (The bottom "Sort by key" is broken)

Fixes #15475

@williamdes
Copy link
Member

williamdes commented Oct 28, 2019 •
edited

Code Looks good to me, I need to check if there is some side effects
was added by 5b1ed4c in #13672

@williamdes williamdes added this to In progress in pull-requests via automation Oct 28, 2019
@williamdes williamdes moved this from In progress to Review in progress in pull-requests Oct 28, 2019
@codecov
Copy link

codecov bot commented Oct 30, 2019

Codecov Report

❗ No coverage uploaded for pull request base (QA_4_9@1a67c19). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             QA_4_9   #15537   +/-   ##
=========================================
  Coverage          ?   55.57%           
  Complexity        ?    14557           
=========================================
  Files             ?      495           
  Lines             ?    71131           
  Branches          ?        0           
=========================================
  Hits              ?    39532           
  Misses            ?    31599           
  Partials          ?        0

@williamdes
Fix Sort By Key issue phpmyadmin#15475
3ad6f48 
Fixes: phpmyadmin#15475

Co-authored-by: Vitalii Medvediev <vitaliim@onehourtranslation.com>
Signed-off-by: William Desportes <williamdes@wdes.fr>
Signed-off-by: Vitalii Medvediev <vitaliim@onehourtranslation.com>
@williamdes williamdes self-assigned this Oct 30, 2019
@williamdes williamdes added this to the 4.9.2 milestone Oct 30, 2019
@williamdes williamdes removed the request for review from MauricioFauth October 30, 2019 22:33
williamdes added a commit that referenced this pull request Oct 30, 2019
@williamdes
Merge #15537 - Sort By Key issues
44e168d 
Fixes: #15475
Pull-request: #15537
Signed-off-by: William Desportes <williamdes@wdes.fr>
@williamdes williamdes merged commit 3ad6f48 into phpmyadmin:QA_4_9 Oct 30, 2019
pull-requests automation moved this from Review in progress to Done Oct 30, 2019
@williamdes
Copy link
Member

Merged, thanks for your contribution @vmedvedev !
I edited your work as 3ad6f48 and added you as a co-author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@williamdes williamdes williamdes approved these changes

Assignees

@williamdes williamdes

Labels
None yet
Projects
pull-requests
  
Done
Milestone
4.9.2
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@vmedvedev @williamdes