Fix operators precedence possible issue #15546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MauricioFauth
approved these changes
Nov 1, 2019
|
I agree with this change, however I think it's better to include this in |
As "==" has priority over "&", it was firstly checking the equality… which were always true… Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
Codecov Report
@@ Coverage Diff @@
## QA_4_9 #15546 +/- ##
=========================================
Coverage ? 52.96%
Complexity ? 13923
=========================================
Files ? 470
Lines ? 61290
Branches ? 0
=========================================
Hits ? 32462
Misses ? 28828
Partials ? 0 |
Done! |
williamdes
approved these changes
Nov 2, 2019
MauricioFauth
approved these changes
Nov 4, 2019
|
Merged, thanks for your contribution! |
MauricioFauth
added a commit
that referenced
this pull request
Nov 4, 2019
Fix operators precedence in DatabaseInterface class Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As "==" has priority over "&", it was firstly checking the equality… which were always true…
To be honnest, I didn't test it, as I don't really know how to test it… I can only guess what was expected to be done.