Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace twig/extensions with phpmyadmin/twig-i18n-extension #15674

Merged
merged 1 commit into from Jan 15, 2020
Merged

Replace twig/extensions with phpmyadmin/twig-i18n-extension #15674

merged 1 commit into from Jan 15, 2020

Conversation

MauricioFauth
Copy link
Member

Fixes #15671.

@williamdes williamdes changed the base branch from QA_4_9 to QA_5_0 December 26, 2019 19:38
@williamdes williamdes added this to In progress in pull-requests via automation Dec 26, 2019
@williamdes williamdes moved this from In progress to To merge in pull-requests Dec 26, 2019
@codecov
Copy link

codecov bot commented Jan 14, 2020 •
edited

Codecov Report

Merging #15674 into QA_5_0 will increase coverage by <.01%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             QA_5_0   #15674      +/-   ##
============================================
+ Coverage     53.02%   53.03%   +<.01%     
- Complexity    14159    14160       +1     
============================================
  Files           482      482              
  Lines         62155    62159       +4     
============================================
+ Hits          32957    32965       +8     
+ Misses        29198    29194       -4

@ibennetch
Copy link
Member

👍

Should we package this on Packagist so it's available as a Composer package instead of needing to point to the vcs repository?

@MauricioFauth
Copy link
Member Author

Should we package this on Packagist so it's available as a Composer package instead of needing to point to the vcs repository?

@ibennetch Yes. I added the VCS repository to be able to test the changes, so when the package is published, I'll remove the repository line. But I can't submit to Packagist myself. You need to do this.

@MauricioFauth MauricioFauth marked this pull request as ready for review January 14, 2020 22:55
pull-requests automation moved this from To merge to Reviewer approved Jan 14, 2020
@williamdes williamdes added this to the 5.0.2 milestone Jan 14, 2020
@williamdes
Copy link
Member

williamdes commented Jan 14, 2020 •
edited

  • will you add a changelog entry ?

I hope #15791 will also be part of the release

https://github.com/phpmyadmin/twig-i18n-extension

@MauricioFauth
Replace twig/extensions with phpmyadmin/twig-i18n-extension
5bc9971 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
@MauricioFauth MauricioFauth merged commit b314a47 into phpmyadmin:QA_5_0 Jan 15, 2020
pull-requests automation moved this from Reviewer approved to Done Jan 15, 2020
@MauricioFauth MauricioFauth deleted the twig-i18n-extension branch January 15, 2020 20:54
williamdes added a commit that referenced this pull request Jan 16, 2020
@williamdes
Fix phpstan error introduced by #15674
0d8e0cd 
Signed-off-by: William Desportes <williamdes@wdes.fr>
@williamdes williamdes mentioned this pull request Jan 28, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@williamdes williamdes williamdes approved these changes

Assignees

@MauricioFauth MauricioFauth

Labels
None yet
Projects
pull-requests
  
Done
Milestone
5.0.2
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@MauricioFauth @ibennetch @williamdes