Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #15905 : Removed empty space after charsets table #15906

Merged
merged 8 commits into from Mar 7, 2020

Conversation

@anirudhsingh20
Copy link
Contributor

anirudhsingh20 commented Feb 3, 2020

Description

There is empty space after the charsets table.

Fixes #15905

Removed empty space after charsets table
charset1

Signed-off-by: Anirudh Singh <anirudhsingh20.as@gmail.com>
…logo link target button look in bootstrap theme (kbd tag) to normal text

Signed-off-by: Anirudh Singh <anirudhsingh20.as@gmail.com>
Signed-off-by: Anirudh Singh <anirudhsingh20.as@gmail.com>
… to make ui better for metro theme and it is working fine for all themes.

Signed-off-by: Anirudh Singh <anirudhsingh20.as@gmail.com>
Signed-off-by: Anirudh Singh <anirudhsingh20.as@gmail.com>
Signed-off-by: Anirudh Singh <anirudhsingh20.as@gmail.com>
Signed-off-by: Anirudh Singh <anirudhsingh20.as@gmail.com>
@williamdes williamdes added this to In progress in pull-requests via automation Feb 3, 2020
@williamdes

This comment has been minimized.

Copy link
Member

williamdes commented Feb 3, 2020

@anirudhsingh20 I would recommend you to install GitKraken so you can view the history
I am afraid you did have to do complicated manipulations between PRs
git remote add phpmyadmin https://git@github.com/phpmyadmin/phpmyadmin.git will be useful

@anirudhsingh20

This comment has been minimized.

Copy link
Contributor Author

anirudhsingh20 commented Feb 3, 2020

Installed, thanks

@williamdes

This comment has been minimized.

Copy link
Member

williamdes commented Feb 3, 2020

@anirudhsingh20 can you rebase onto latest commit of phpmyadmin master branch and then squash all your commits using the reset soft feature?

@anirudhsingh20

This comment has been minimized.

Copy link
Contributor Author

anirudhsingh20 commented Feb 3, 2020

okay, sure. @williamdes can you please tell me how can I understand complete codebase? and any suggestions?

@williamdes

This comment has been minimized.

Copy link
Member

williamdes commented Feb 3, 2020

okay, sure. @williamdes can you please tell me how can I understand complete codebase? and any suggestions?

So I think it is not possible to now the full codebase, only time trying to debug and understand things can help you.
I do not now a lot of the codebase.
My suggestion would be to try to fix issues to build the knowledge

@anirudhsingh20

This comment has been minimized.

Copy link
Contributor Author

anirudhsingh20 commented Feb 3, 2020

pull-requests automation moved this from In progress to Reviewer approved Mar 7, 2020
@mauriciofauth mauriciofauth merged commit c47a25d into phpmyadmin:master Mar 7, 2020
3 of 4 checks passed
3 of 4 checks passed
continuous-integration/travis-ci/pr The Travis CI build failed
Details
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
DCO DCO
Details
codeclimate All good!
Details
pull-requests automation moved this from Reviewer approved to Done Mar 7, 2020
@mauriciofauth mauriciofauth self-assigned this Mar 7, 2020
@mauriciofauth mauriciofauth mentioned this pull request Mar 7, 2020
@williamdes williamdes added this to the 5.1.0 milestone Mar 7, 2020
@williamdes williamdes added the ui label Mar 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
pull-requests
  
Done
Linked issues

Successfully merging this pull request may close these issues.

3 participants
You can’t perform that action at this time.