Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #15898 - escape tbl_storage_engine argument #16004

Merged
merged 3 commits into from Mar 19, 2020

Conversation

@williamdes
Copy link
Member

williamdes commented Feb 28, 2020

Fixes #15898

The issue is public, so is the fix.

I am not sure this will prevent building bad queries because is is missing quotes at end and start

Do I make the change for 4.9 @ibennetch ?

williamdes added 3 commits Feb 28, 2020
Signed-off-by: William Desportes <williamdes@wdes.fr>
Signed-off-by: William Desportes <williamdes@wdes.fr>
Depends on 20e3d2f

Signed-off-by: William Desportes <williamdes@wdes.fr>
@williamdes williamdes added this to In progress in pull-requests via automation Mar 6, 2020
@williamdes williamdes moved this from In progress to To merge in pull-requests Mar 6, 2020
@williamdes williamdes merged commit e1f5dfc into phpmyadmin:QA_5_0 Mar 19, 2020
1 of 2 checks passed
1 of 2 checks passed
continuous-integration/travis-ci/pr The Travis CI build failed
Details
DCO DCO
Details
pull-requests automation moved this from To merge to Done Mar 19, 2020
@williamdes williamdes linked an issue that may be closed by this pull request Mar 19, 2020
@williamdes williamdes self-assigned this Mar 19, 2020
@williamdes williamdes deleted the williamdes:fix/15898 branch Mar 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
pull-requests
  
Done
Linked issues

Successfully merging this pull request may close these issues.

2 participants
You can’t perform that action at this time.