Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve performance of dependency injection system by removing yaml parsing #16007

Merged
merged 4 commits into from Mar 5, 2020

Conversation

@williamdes
Copy link
Member

williamdes commented Mar 4, 2020

Description

Ref #16005

@williamdes williamdes requested a review from mauriciofauth Mar 4, 2020
Ref: 380707f

Signed-off-by: William Desportes <williamdes@wdes.fr>
@williamdes williamdes force-pushed the williamdes:perf/di branch from d7bab3a to 72d35d8 Mar 4, 2020
libraries/services.php Outdated Show resolved Hide resolved
libraries/services_loader.php Outdated Show resolved Hide resolved
Signed-off-by: William Desportes <williamdes@wdes.fr>
@williamdes williamdes force-pushed the williamdes:perf/di branch from 72d35d8 to ae182cd Mar 4, 2020
williamdes added 2 commits Mar 5, 2020
Signed-off-by: William Desportes <williamdes@wdes.fr>
Signed-off-by: William Desportes <williamdes@wdes.fr>
@codecov

This comment has been minimized.

Copy link

codecov bot commented Mar 5, 2020

Codecov Report

Merging #16007 into master will decrease coverage by 0.94%.
The diff coverage is 0%.

@@             Coverage Diff              @@
##             master   #16007      +/-   ##
============================================
- Coverage     52.51%   51.57%   -0.95%     
  Complexity    14958    14958              
============================================
  Files           468      471       +3     
  Lines         61045    62158    +1113     
============================================
  Hits          32058    32058              
- Misses        28987    30100    +1113
@williamdes williamdes self-assigned this Mar 5, 2020
@williamdes williamdes added this to Code base in Enhancements Mar 5, 2020
Copy link
Member

ibennetch left a comment

👍

@williamdes williamdes merged commit c9916c2 into phpmyadmin:master Mar 5, 2020
1 of 3 checks passed
1 of 3 checks passed
codeclimate 2 issues to fix
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
DCO DCO
Details
@williamdes williamdes deleted the williamdes:perf/di branch Mar 5, 2020
@williamdes

This comment has been minimized.

Copy link
Member Author

williamdes commented Mar 5, 2020

Thank you for the review, I really appreciate ;)

@williamdes williamdes added this to the 5.1.0 milestone Mar 5, 2020
williamdes added a commit to williamdes/phpmyadmintest that referenced this pull request Mar 6, 2020
Signed-off-by: William Desportes <williamdes@wdes.fr>
williamdes added a commit that referenced this pull request Mar 6, 2020
Signed-off-by: William Desportes <williamdes@wdes.fr>
williamdes added a commit that referenced this pull request Mar 7, 2020
Signed-off-by: William Desportes <williamdes@wdes.fr>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Enhancements
  
Code base
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.