Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

autocomplete attributes added #16011

Merged
merged 3 commits into from Mar 10, 2020
Merged

autocomplete attributes added #16011

merged 3 commits into from Mar 10, 2020

Conversation

Pankaj-Wadhwani
Copy link
Contributor

@Pankaj-Wadhwani Pankaj-Wadhwani commented Mar 4, 2020 •
edited by williamdes

Signed-off-by: Pankaj Wadhwani pankajwadhwani100@gmail.com

Description

Added autocomplete : on in form tag,username field and password field.

Ref #16001

Before submitting pull request, please review the following checklist:

  • Make sure you have read our CONTRIBUTING.md document.
  • Make sure you are making a pull request against the correct branch. For example, for bug fixes in a released version use the corresponding QA branch and for new features use the master branch. If you have a doubt, you can ask as a comment in the bug report or on the mailing list.
  • Every commit has proper Signed-off-by line as described in our DCO. This ensures that the work you're submitting is your own creation.
  • Every commit has a descriptive commit message.
  • Every commit is needed on its own, if you have just minor fixes to previous commits, you can squash them.
  • Any new functionality is covered by tests.

@Pankaj-Wadhwani
autocomplete attributes added
cc7a8a1 
Signed-off-by: Pankaj Wadhwani <pankajwadhwani100@gmail.com>
@williamdes williamdes mentioned this pull request Mar 4, 2020
Closed
6 tasks
MauricioFauth
MauricioFauth reviewed Mar 4, 2020
View reviewed changes
Copy link
Member

@MauricioFauth MauricioFauth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason to add autocomplete for username and password fields?

@MauricioFauth
Copy link
Member

Okay. It's related to #16001.

@MauricioFauth MauricioFauth linked an issue Mar 4, 2020 that may be closed by this pull request
Input elements should have autocomplete attributes #16001
Closed
@MauricioFauth MauricioFauth removed a link to an issue Mar 4, 2020
Input elements should have autocomplete attributes #16001
Closed
@williamdes
Copy link
Member

From what I linked in #16001 https://www.chromium.org/developers/design-documents/form-styles-that-chromium-understands the value could be more precise then on

@Pankaj-Wadhwani
Copy link
Contributor Author

Pankaj-Wadhwani commented Mar 5, 2020 •
edited

what if i do like this,
form tag has autocomplete="off"
username has autocomplete="pma_username"
password has autocomplete="pma_password"
@williamdes

@williamdes williamdes added this to In progress in pull-requests via automation Mar 6, 2020
@williamdes williamdes moved this from In progress to Review in progress in pull-requests Mar 6, 2020
@williamdes
Copy link
Member

what if i do like this,
form tag has autocomplete="off"
username has autocomplete="pma_username"
password has autocomplete="pma_password"
@williamdes

I am not sure this is standard, could you do some research ?

@Pankaj-Wadhwani
Copy link
Contributor Author

I am not sure this is standard, could you do some research ?

yes

@Pankaj-Wadhwani
Copy link
Contributor Author

I changed the commit in pull request,please review it. @williamdes

MauricioFauth
MauricioFauth requested changes Mar 7, 2020
View reviewed changes
templates/login/form.twig Outdated Show resolved Hide resolved
templates/login/form.twig Outdated Show resolved Hide resolved
@Pankaj-Wadhwani
autocomplete attributes added
41b1059 
Signed-off-by: Pankaj Wadhwani <pankajwadhwani100@gmail.com>
@Pankaj-Wadhwani Pankaj-Wadhwani force-pushed the autocomplete branch 2 times, most recently from 4c913ab to 41b1059 Compare March 7, 2020 21:52
@Pankaj-Wadhwani
requested changes done
4d6c352 
Signed-off-by: Pankaj Wadhwani <pankajwadhwani100@gmail.com>
@Pankaj-Wadhwani
Copy link
Contributor Author

Review my commit @MauricioFauth

pull-requests automation moved this from Review in progress to Reviewer approved Mar 10, 2020
@williamdes williamdes self-assigned this Mar 10, 2020
@williamdes williamdes added the enhancement A feature request for improving phpMyAdmin label Mar 10, 2020
@williamdes williamdes added this to the 5.1.0 milestone Mar 10, 2020
@williamdes williamdes merged commit 9e98273 into phpmyadmin:master Mar 10, 2020
pull-requests automation moved this from Reviewer approved to Done Mar 10, 2020
williamdes added a commit that referenced this pull request Mar 10, 2020
@williamdes
Fix testAuthError after merge of #16011
e225229 
Signed-off-by: William Desportes <williamdes@wdes.fr>
@williamdes
Copy link
Member

Thank you @Pankaj-Wadhwani for your contribution!

@Pankaj-Wadhwani
Copy link
Contributor Author

Thank you @Pankaj-Wadhwani for your contribution!

My pleasure.
Would love to contribute more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MauricioFauth MauricioFauth MauricioFauth approved these changes

Assignees

@williamdes williamdes

Labels
enhancement A feature request for improving phpMyAdmin
Projects
pull-requests
  
Done
Milestone
5.1.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Pankaj-Wadhwani @MauricioFauth @williamdes