Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

autocomplete attributes added #16011

Merged
merged 3 commits into from Mar 10, 2020
Merged

Conversation

@Pankaj-Wadhwani
Copy link
Contributor

Pankaj-Wadhwani commented Mar 4, 2020

Signed-off-by: Pankaj Wadhwani pankajwadhwani100@gmail.com

Description

Added autocomplete : on in form tag,username field and password field.

Ref #16001

Before submitting pull request, please review the following checklist:

  • Make sure you have read our CONTRIBUTING.md document.
  • Make sure you are making a pull request against the correct branch. For example, for bug fixes in a released version use the corresponding QA branch and for new features use the master branch. If you have a doubt, you can ask as a comment in the bug report or on the mailing list.
  • Every commit has proper Signed-off-by line as described in our DCO. This ensures that the work you're submitting is your own creation.
  • Every commit has a descriptive commit message.
  • Every commit is needed on its own, if you have just minor fixes to previous commits, you can squash them.
  • Any new functionality is covered by tests.
Signed-off-by: Pankaj Wadhwani <pankajwadhwani100@gmail.com>
@williamdes williamdes mentioned this pull request Mar 4, 2020
6 of 6 tasks complete
Copy link
Member

mauriciofauth left a comment

Is there a reason to add autocomplete for username and password fields?

@mauriciofauth

This comment has been minimized.

Copy link
Member

mauriciofauth commented Mar 4, 2020

Okay. It's related to #16001.

@williamdes

This comment has been minimized.

Copy link
Member

williamdes commented Mar 4, 2020

From what I linked in #16001 https://www.chromium.org/developers/design-documents/form-styles-that-chromium-understands the value could be more precise then on

@Pankaj-Wadhwani

This comment has been minimized.

Copy link
Contributor Author

Pankaj-Wadhwani commented Mar 5, 2020

what if i do like this,
form tag has autocomplete="off"
username has autocomplete="pma_username"
password has autocomplete="pma_password"
@williamdes

@williamdes williamdes added this to In progress in pull-requests via automation Mar 6, 2020
@williamdes williamdes moved this from In progress to Review in progress in pull-requests Mar 6, 2020
@williamdes

This comment has been minimized.

Copy link
Member

williamdes commented Mar 6, 2020

what if i do like this,
form tag has autocomplete="off"
username has autocomplete="pma_username"
password has autocomplete="pma_password"
@williamdes

I am not sure this is standard, could you do some research ?

@Pankaj-Wadhwani

This comment has been minimized.

Copy link
Contributor Author

Pankaj-Wadhwani commented Mar 6, 2020

I am not sure this is standard, could you do some research ?

yes

@Pankaj-Wadhwani

This comment has been minimized.

Copy link
Contributor Author

Pankaj-Wadhwani commented Mar 7, 2020

I changed the commit in pull request,please review it. @williamdes

templates/login/form.twig Outdated Show resolved Hide resolved
templates/login/form.twig Outdated Show resolved Hide resolved
Signed-off-by: Pankaj Wadhwani <pankajwadhwani100@gmail.com>
@Pankaj-Wadhwani Pankaj-Wadhwani force-pushed the Pankaj-Wadhwani:autocomplete branch 2 times, most recently from 4c913ab to 41b1059 Mar 7, 2020
Signed-off-by: Pankaj Wadhwani <pankajwadhwani100@gmail.com>
@Pankaj-Wadhwani

This comment has been minimized.

Copy link
Contributor Author

Pankaj-Wadhwani commented Mar 8, 2020

Review my commit @mauriciofauth

pull-requests automation moved this from Review in progress to Reviewer approved Mar 10, 2020
@williamdes williamdes self-assigned this Mar 10, 2020
@williamdes williamdes added this to the 5.1.0 milestone Mar 10, 2020
@williamdes williamdes merged commit 9e98273 into phpmyadmin:master Mar 10, 2020
2 of 3 checks passed
2 of 3 checks passed
continuous-integration/travis-ci/pr The Travis CI build failed
Details
DCO DCO
Details
codeclimate All good!
Details
pull-requests automation moved this from Reviewer approved to Done Mar 10, 2020
williamdes added a commit that referenced this pull request Mar 10, 2020
Signed-off-by: William Desportes <williamdes@wdes.fr>
@williamdes

This comment has been minimized.

Copy link
Member

williamdes commented Mar 10, 2020

Thank you @Pankaj-Wadhwani for your contribution!

@Pankaj-Wadhwani

This comment has been minimized.

Copy link
Contributor Author

Pankaj-Wadhwani commented Mar 11, 2020

Thank you @Pankaj-Wadhwani for your contribution!

My pleasure.
Would love to contribute more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
pull-requests
  
Done
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.