Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Don't fire keyboard shortcuts while SQL query area is focused #16026
Fixes a bug where the keyboard shortcuts functions fire while typing in the SQL query area. Problem is that the SQL query area is not (always) a `<textarea>` but a `<div contenteditable="true">` Signed-off-by: Jan Nitsche <firstname.lastname@example.org> Signed-off-by: JayEn84 <4518738+JayEn84@users.noreply.github.com>
@@ Coverage Diff @@ ## master #16026 +/- ## ========================================= Coverage ? 51.55% Complexity ? 14963 ========================================= Files ? 471 Lines ? 62161 Branches ? 0 ========================================= Hits ? 32048 Misses ? 30113 Partials ? 0
while testing I could not validate the fix because something seems wrong
when I type
when I hit tab
So it seems that this only fixes the problem in desktop browser that are sending mobile client header information.
I honestly don't know how to solve this at the moment, because it seems the wrong HTML element is passed to the function that checks if the shortcut functionalities should fire or not.