Fix column definition form not showing default value#16366
Merged
MauricioFauth merged 1 commit intophpmyadmin:QA_5_0from Sep 20, 2020
Merged
Fix column definition form not showing default value#16366MauricioFauth merged 1 commit intophpmyadmin:QA_5_0from
MauricioFauth merged 1 commit intophpmyadmin:QA_5_0from
Conversation
Codecov Report
@@ Coverage Diff @@
## QA_5_0 #16366 +/- ##
============================================
- Coverage 53.19% 53.19% -0.01%
- Complexity 14270 14278 +8
============================================
Files 482 482
Lines 62331 62347 +16
============================================
+ Hits 33159 33167 +8
- Misses 29172 29180 +8 |
williamdes
approved these changes
Sep 20, 2020
Member
Author
Add a column that has an user defined default value to the central columns, then try to bulk edit that central column. The input field for the default value will be empty. |
MauricioFauth
force-pushed
the
column-default-issue
branch
from
bccc0ab to
8ea05b2
Compare
Introduced by 5d0fd81 Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
MauricioFauth
force-pushed
the
column-default-issue
branch
from
8ea05b2 to
8894f04
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To reproduce:
Add a column that has an user defined default value to the central columns, then try to bulk edit that central column. The input field for the default value will be empty.
Introduced by 5d0fd81.