Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade Bootstrap to version 5 #16521

Merged
merged 3 commits into from Dec 21, 2020
Merged

Upgrade Bootstrap to version 5 #16521

merged 3 commits into from Dec 21, 2020

Conversation

MauricioFauth
Copy link
Member

@MauricioFauth MauricioFauth commented Dec 8, 2020 •
edited

Bootstrap 5 has RTL support integrated. But removed support for Internet Explorer.

Dropped support for Internet Explorer 10 and 11
Dropped support for Microsoft Edge < 16
Dropped support for Firefox < 60
Dropped support for Safari < 10
Dropped support for iOS Safari < 10
Dropped support for Chrome < 60
Dropped support for Android < 6

williamdes
williamdes approved these changes Dec 8, 2020
View reviewed changes
Copy link
Member

@williamdes williamdes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you edit the sync js vendor script if needed?

package.json Outdated
@@ -13,8 +13,9 @@
"@babel/cli": "^7.12.1",
"@babel/core": "^7.12.3",
"@babel/preset-env": "^7.12.1",
"@popperjs/core": "^2.5.4",
Copy link
Member

@williamdes williamdes Dec 8, 2020 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They did not succeed to remove this?

@williamdes williamdes added enhancement A feature request for improving phpMyAdmin ui Issues relating to the user interface labels Dec 8, 2020
@ibennetch
Copy link
Member

I'm fine with dropping support for Internet Explorer (and the rest of this), but I wonder if we need to add a note in doc/require.rst at the "Web browser" section. I know IE is old, but some enterprise sites were slow to move to Edge and I think we should document the change somewhere.

@ibennetch
Copy link
Member

I might suggest holding this off until 5.2, also.

@MauricioFauth
Copy link
Member Author

I might suggest holding this off until 5.2, also.

I agree.

@MauricioFauth MauricioFauth added this to the 5.2.0 milestone Dec 8, 2020
@MauricioFauth
Upgrade Bootstrap to version 5
7127284 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
@MauricioFauth MauricioFauth marked this pull request as ready for review December 21, 2020 18:09
@MauricioFauth
Fix renamed Bootstrap 5 classes
6408b71 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
@MauricioFauth
Update web browser support in doc/require.rst
178882b 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
@MauricioFauth MauricioFauth self-assigned this Dec 21, 2020
@MauricioFauth MauricioFauth merged commit c1932b7 into phpmyadmin:master Dec 21, 2020
@MauricioFauth MauricioFauth deleted the bootstrap-5 branch December 21, 2020 18:49
@MauricioFauth MauricioFauth mentioned this pull request May 14, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@williamdes williamdes williamdes approved these changes

Assignees

@MauricioFauth MauricioFauth

Labels
enhancement A feature request for improving phpMyAdmin ui Issues relating to the user interface
Projects
None yet
Milestone
5.2.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@MauricioFauth @ibennetch @williamdes