Bump PHP minimum version to 7.2 #16555
Conversation
|
We should continue to support a version for security fixes to help
distributions with LTS PHP versions. Would that be phpMyAdmin 5.0 or 5.1?
|
I thought about having a planned schedule for releases and support. The following table presents three ideas:
If you think that two years of support (regular + security) is too short, we could increase one year of support, either for regular support or for security support. What do you think about this? Edit: Changed phpMyAdmin 4.9 "End of Security Support" date and added PHP 7.0 EOL date. |
|
Additional information: Debian:
Ubuntu:
Fedora / RHEL / CentOS: From Remi Collet's comment:
|
|
Your release and support table looks good to me ! |
Twig and Symfony related packages requires 7.2.5, so requiring just 7.2 would not be accurate enough. |
|
Some reasoning behind the ideas:
I think it's good to have a defined release cycle and we already release minor versions once a year. 5.1.0-rc1 in Dec 2020, 5.0 in Dec 2019, 4.8 in April 2018, 4.7 in March 2017. Choosing a quarter of the year for the release seems like a more flexible interval than choosing a month.
Instead of ending regular support when the next minor is released and not knowing when to stop security support, we can be more predictable by doing support for a fixed time. This works better with a defined release cycle.
We can bump the minimum PHP version in a predictable way and we can support distributions with LTS PHP versions as well, by staying behind enough with the minimum PHP version. |
|
@MauricioFauth I think it's a good idea to have a schedule it would be super useful for everyone! |
Codecov Report
@@ Coverage Diff @@
## master #16555 +/- ##
============================================
+ Coverage 52.84% 52.96% +0.11%
Complexity 15101 15101
============================================
Files 471 471
Lines 62582 62212 -370
============================================
- Hits 33074 32948 -126
+ Misses 29508 29264 -244
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
PHP officially ended support for PHP 7.2 on 2020-11-30. So it is safe to bump the minimum version to PHP 7.2 for phpMyAdmin 5.2, which is likely to be released only in the second half of 2021. Related to phpmyadmin#15607 Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
Bump minimum PHP version to 7.2 Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
PHP officially ended support for PHP 7.2 on 2020-11-30. So it is safe to bump the minimum version to PHP 7.2 for phpMyAdmin 5.2, which is likely to be released only in the second half of 2021.
Related to #15607.