Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove printview.css theme files #17171

Merged
merged 1 commit into from Oct 31, 2021

Conversation

MauricioFauth
Copy link
Member

Uses CSS's print media query instead of a dedicated file for print.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
@MauricioFauth MauricioFauth added this to In progress in pull-requests via automation Oct 31, 2021
@MauricioFauth MauricioFauth added this to the 5.2.0 milestone Oct 31, 2021
@codecov
Copy link

codecov bot commented Oct 31, 2021

Codecov Report

Merging #17171 (220ed30) into master (78104be) will decrease coverage by 0.03%.
The diff coverage is 20.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #17171      +/-   ##
============================================
- Coverage     47.74%   47.71%   -0.04%     
  Complexity    16662    16662              
============================================
  Files           577      577              
  Lines         60498    60496       -2     
============================================
- Hits          28883    28863      -20     
- Misses        31615    31633      +18     
Flag Coverage Δ
dbase-extension 47.49% <20.00%> (-0.04%) ⬇️
recode-extension 47.45% <20.00%> (+0.02%) ⬆️
unit-7.2-ubuntu-latest 47.45% <20.00%> (+0.03%) ⬆️
unit-7.3-ubuntu-latest 50.37% <20.00%> (-0.03%) ⬇️
unit-7.4-ubuntu-latest 50.42% <20.00%> (-0.03%) ⬇️
unit-8.0-ubuntu-latest 50.52% <20.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
libraries/classes/Config.php 64.95% <0.00%> (ø)
...asses/Controllers/JavaScriptMessagesController.php 99.56% <ø> (-0.01%) ⬇️
libraries/classes/Html/Generator.php 17.59% <0.00%> (ø)
libraries/classes/Display/Results.php 60.40% <33.33%> (ø)
libraries/classes/Charsets.php 50.90% <0.00%> (-30.91%) ⬇️
...ries/classes/Plugins/Auth/AuthenticationConfig.php 70.14% <0.00%> (-5.98%) ⬇️
libraries/classes/Gis/GisMultiPoint.php 87.50% <0.00%> (-1.32%) ⬇️
libraries/classes/Header.php 87.27% <0.00%> (-1.10%) ⬇️
libraries/classes/Gis/GisMultiPolygon.php 78.04% <0.00%> (-0.82%) ⬇️
libraries/classes/Transformations.php 60.60% <0.00%> (-0.51%) ⬇️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 78104be...220ed30. Read the comment docs.

@MauricioFauth MauricioFauth merged commit 000f6c0 into phpmyadmin:master Oct 31, 2021
pull-requests automation moved this from In progress to Done Oct 31, 2021
@MauricioFauth MauricioFauth deleted the printview-removal branch October 31, 2021 22:11
@williamdes williamdes self-assigned this Oct 31, 2021
@williamdes williamdes added enhancement A feature request for improving phpMyAdmin refactoring ui Issues relating to the user interface labels Oct 31, 2021
@MauricioFauth MauricioFauth self-assigned this Nov 1, 2021
MauricioFauth added a commit that referenced this pull request Nov 1, 2021
Remove printview.css theme files

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
@MauricioFauth MauricioFauth restored the printview-removal branch December 9, 2021 14:34
@MauricioFauth MauricioFauth deleted the printview-removal branch December 9, 2021 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement A feature request for improving phpMyAdmin refactoring ui Issues relating to the user interface
Projects
pull-requests
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants