Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix db selection when nav tree is disabled #17198

Merged
merged 1 commit into from Nov 21, 2021

Conversation

MauricioFauth
Copy link
Member

@MauricioFauth MauricioFauth commented Nov 20, 2021

$cfg['ShowDatabasesNavigationAsTree'] = false;

After selecting a database when the navigation tree is disabled, it is not possible to select another database.

@MauricioFauth MauricioFauth added this to In progress in pull-requests via automation Nov 20, 2021
@MauricioFauth MauricioFauth added this to the 5.1.2 milestone Nov 20, 2021
@MauricioFauth MauricioFauth self-assigned this Nov 20, 2021
@codecov
Copy link

codecov bot commented Nov 20, 2021

Codecov Report

Merging #17198 (d7ced91) into QA_5_1 (90d6324) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             QA_5_1   #17198   +/-   ##
=========================================
  Coverage     57.78%   57.78%           
  Complexity    15324    15324           
=========================================
  Files           471      471           
  Lines         62125    62127    +2     
=========================================
+ Hits          35897    35899    +2     
  Misses        26228    26228           
Flag Coverage Δ
arch-7-amd64 61.14% <100.00%> (+<0.01%) ⬆️
arch-7-arm32v6 61.02% <100.00%> (+<0.01%) ⬆️
arch-7-arm32v7 61.02% <100.00%> (+<0.01%) ⬆️
arch-7-arm64v8 61.14% <100.00%> (+<0.01%) ⬆️
arch-7-i386 61.02% <100.00%> (+<0.01%) ⬆️
arch-7-ppc64le 61.14% <100.00%> (+<0.01%) ⬆️
arch-7-s390x 60.99% <100.00%> (+<0.01%) ⬆️
dbase-extension 57.47% <100.00%> (+<0.01%) ⬆️
recode-extension 57.42% <100.00%> (+<0.01%) ⬆️
unit-7.1-ubuntu-latest 57.42% <100.00%> (+<0.01%) ⬆️
unit-7.2-ubuntu-latest 57.60% <100.00%> (+<0.01%) ⬆️
unit-7.3-ubuntu-latest 61.16% <100.00%> (+<0.01%) ⬆️
unit-7.4-ubuntu-latest 61.16% <100.00%> (+<0.01%) ⬆️
unit-8.0-ubuntu-latest 61.21% <100.00%> (+<0.01%) ⬆️
unit-8.1-ubuntu-latest 61.10% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
libraries/classes/Navigation/NavigationTree.php 63.19% <100.00%> (+0.08%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 90d6324...d7ced91. Read the comment docs.

pull-requests automation moved this from In progress to Reviewer approved Nov 20, 2021
$cfg['ShowDatabasesNavigationAsTree'] = false;

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
@MauricioFauth MauricioFauth merged commit 51a9540 into phpmyadmin:QA_5_1 Nov 21, 2021
pull-requests automation moved this from Reviewer approved to Done Nov 21, 2021
@MauricioFauth MauricioFauth deleted the nav-db-select-fix branch November 21, 2021 15:22
@MauricioFauth MauricioFauth restored the nav-db-select-fix branch December 9, 2021 14:34
@MauricioFauth MauricioFauth deleted the nav-db-select-fix branch December 9, 2021 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
pull-requests
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants