Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redesign the export/import pages to use Bootstrap components #17203

Merged
merged 1 commit into from Nov 26, 2021

Conversation

MauricioFauth
Copy link
Member

No description provided.

@MauricioFauth MauricioFauth added this to In progress in pull-requests via automation Nov 23, 2021
@MauricioFauth MauricioFauth added the ui Issues relating to the user interface label Nov 23, 2021
@MauricioFauth MauricioFauth self-assigned this Nov 23, 2021
@codecov
Copy link

codecov bot commented Nov 23, 2021

Codecov Report

Merging #17203 (360b7e4) into master (4001460) will increase coverage by 0.03%.
The diff coverage is 0.00%.

❗ Current head 360b7e4 differs from pull request most recent head fbd5b0a. Consider uploading reports for the commit fbd5b0a to get more accurate results
Impacted file tree graph

@@             Coverage Diff              @@
##             master   #17203      +/-   ##
============================================
+ Coverage     48.37%   48.40%   +0.03%     
  Complexity    16780    16780              
============================================
  Files           578      578              
  Lines         60782    60785       +3     
============================================
+ Hits          29402    29424      +22     
+ Misses        31380    31361      -19     
Flag Coverage Δ
dbase-extension 48.14% <0.00%> (-0.02%) ⬇️
recode-extension 48.10% <0.00%> (-0.08%) ⬇️
unit-7.2-ubuntu-latest 48.11% <0.00%> (+0.02%) ⬆️
unit-7.3-ubuntu-latest 51.07% <0.00%> (-0.03%) ⬇️
unit-7.4-ubuntu-latest 51.10% <0.00%> (+0.06%) ⬆️
unit-8.0-ubuntu-latest 51.19% <0.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../classes/Controllers/Database/ImportController.php 0.00% <0.00%> (ø)
...es/classes/Controllers/Server/ImportController.php 0.00% <0.00%> (ø)
...ies/classes/Controllers/Table/ImportController.php 0.00% <0.00%> (ø)
libraries/classes/Twig/UtilExtension.php 0.00% <ø> (ø)
libraries/classes/StorageEngine.php 64.00% <0.00%> (-5.00%) ⬇️
libraries/classes/Gis/GisMultiPolygon.php 78.04% <0.00%> (-0.82%) ⬇️
libraries/classes/Util.php 53.15% <0.00%> (+0.09%) ⬆️
libraries/classes/Partitioning/Partition.php 25.80% <0.00%> (+8.60%) ⬆️
libraries/classes/Transformations.php 60.60% <0.00%> (+12.62%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4001460...fbd5b0a. Read the comment docs.

pull-requests automation moved this from In progress to Reviewer approved Nov 23, 2021
@MauricioFauth MauricioFauth changed the title Redesign the export page to use Bootstrap components Redesign the export/import pages to use Bootstrap components Nov 24, 2021
@MauricioFauth MauricioFauth force-pushed the export-page-layout branch 2 times, most recently from a5d8558 to 148ced0 Compare November 25, 2021 00:05
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
@MauricioFauth MauricioFauth marked this pull request as ready for review November 25, 2021 16:38
@MauricioFauth MauricioFauth merged commit e1b0750 into phpmyadmin:master Nov 26, 2021
pull-requests automation moved this from Reviewer approved to Done Nov 26, 2021
@MauricioFauth MauricioFauth deleted the export-page-layout branch November 26, 2021 16:47
@MauricioFauth MauricioFauth restored the export-page-layout branch December 9, 2021 14:34
@MauricioFauth MauricioFauth deleted the export-page-layout branch December 9, 2021 14:37
@williamdes williamdes added this to the 5.2.0 milestone Mar 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ui Issues relating to the user interface
Projects
pull-requests
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants