Bug fix: Fix triple HTML encoding #17247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some values were encoded into HTML entities thrice. This commit removes unnecessary HTML escaping. Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
The values of < > ' " & are double escaped in the confirmation dialog. Since the values are inserted via twig into HTML, there is no need to escape them twice. Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
Codecov Report
@@ Coverage Diff @@
## QA_5_1 #17247 +/- ##
============================================
- Coverage 57.78% 57.78% -0.01%
+ Complexity 15324 15323 -1
============================================
Files 471 471
Lines 62127 62124 -3
============================================
- Hits 35899 35896 -3
Misses 26228 26228
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
williamdes
reviewed
Dec 19, 2021
Comment on lines
-325
to
+328
| $columns = []; | ||
| foreach ($columnList as $column) { | ||
| $columns[] = htmlspecialchars($column); | ||
| } | ||
| if ($GLOBALS['cfg']['NaturalOrder']) { | ||
| usort($columns, 'strnatcasecmp'); | ||
| usort($columnList, 'strnatcasecmp'); | ||
| } | ||
| $this->response->addJSON('columns', $columns); | ||
|
|
||
| $this->response->addJSON('columns', $columnList); |
There was a problem hiding this comment.
I can confirm this part of the fix in the column select to add a foreign key when the column has a strange name
williamdes
approved these changes
Dec 19, 2021
There is also 1 more error when you try to delete a column called I hope these steps can be reproduced, let me know if not and I will prepare more detailed steps. |
MauricioFauth
approved these changes
Dec 21, 2021
MauricioFauth
added a commit
that referenced
this pull request
Dec 21, 2021
Related to #17247. Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
MauricioFauth
added a commit
that referenced
this pull request
Dec 21, 2021
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some values were double or even triple encoded in the HTML/JS. This resulted in garbled up text. This PR removed HTML escaping from places where it is not needed.
Cherry-picked from #17246 onto QA_5_1 branch