Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace vendor_config.php constants with an array #17257

Merged

Conversation

MauricioFauth
Copy link
Member

Constants are hard to deal with, so this pull request replaces the constants in the libraries/vendor_config.php file with an array.

The constants have been moved to the libraries/constants.php file and can be removed later.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
@MauricioFauth MauricioFauth added this to In progress in pull-requests via automation Dec 26, 2021
@codecov
Copy link

codecov bot commented Dec 26, 2021

Codecov Report

Merging #17257 (1e542cd) into master (8fd8c35) will decrease coverage by 0.76%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #17257      +/-   ##
============================================
- Coverage     48.31%   47.54%   -0.77%     
  Complexity    16677    16677              
============================================
  Files           579      580       +1     
  Lines         60091    59482     -609     
============================================
- Hits          29033    28282     -751     
- Misses        31058    31200     +142     
Flag Coverage Δ
dbase-extension 47.42% <0.00%> (-0.07%) ⬇️
recode-extension 47.44% <0.00%> (-0.03%) ⬇️
unit-7.2-ubuntu-latest 47.43% <0.00%> (-0.60%) ⬇️
unit-7.3-ubuntu-latest 50.10% <0.00%> (-0.05%) ⬇️
unit-7.4-ubuntu-latest 50.19% <0.00%> (+0.10%) ⬆️
unit-8.0-ubuntu-latest ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
index.php 0.00% <0.00%> (ø)
js/messages.php 0.00% <0.00%> (ø)
libraries/classes/Command/SetVersionCommand.php 61.53% <ø> (ø)
libraries/constants.php 0.00% <0.00%> (ø)
libraries/vendor_config.php 0.00% <0.00%> (ø)
setup/lib/common.inc.php 0.00% <ø> (ø)
show_config_errors.php 0.00% <ø> (ø)
url.php 0.00% <ø> (ø)
libraries/classes/Config/Descriptions.php 4.49% <0.00%> (-45.03%) ⬇️
libraries/classes/Charsets.php 52.00% <0.00%> (-30.70%) ⬇️
... and 133 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5940dc7...1e542cd. Read the comment docs.

pull-requests automation moved this from In progress to Reviewer approved Dec 26, 2021
@williamdes williamdes added this to the 5.2.0 milestone Dec 26, 2021
@MauricioFauth MauricioFauth merged commit 5ff0aa9 into phpmyadmin:master Dec 26, 2021
pull-requests automation moved this from Reviewer approved to Done Dec 26, 2021
@MauricioFauth MauricioFauth deleted the vendor-config-constants branch December 26, 2021 22:08
MauricioFauth added a commit that referenced this pull request Dec 26, 2021
[ci skip]

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
@MauricioFauth MauricioFauth self-assigned this Dec 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
pull-requests
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants