Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SameSite to session cookie for PHP 7.2 #17387

Merged

Conversation

MauricioFauth
Copy link
Member

- Related to phpmyadmin#16981

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
@codecov
Copy link

codecov bot commented Feb 15, 2022

Codecov Report

Merging #17387 (2fd5540) into QA_5_1 (340bff0) will decrease coverage by 0.00%.
The diff coverage is 11.11%.

Impacted file tree graph

@@             Coverage Diff              @@
##             QA_5_1   #17387      +/-   ##
============================================
- Coverage     58.06%   58.05%   -0.01%     
- Complexity    15407    15408       +1     
============================================
  Files           472      472              
  Lines         62625    62628       +3     
============================================
- Hits          36362    36361       -1     
- Misses        26263    26267       +4     
Flag Coverage Δ
arch-7-amd64 61.25% <11.11%> (-0.01%) ⬇️
arch-7-arm32v6 61.14% <11.11%> (-0.01%) ⬇️
arch-7-arm32v7 61.14% <11.11%> (-0.01%) ⬇️
arch-7-arm64v8 61.25% <11.11%> (-0.01%) ⬇️
arch-7-i386 61.14% <11.11%> (-0.01%) ⬇️
arch-7-ppc64le 61.25% <11.11%> (-0.01%) ⬇️
arch-7-s390x 61.11% <11.11%> (-0.01%) ⬇️
dbase-extension 57.60% <11.11%> (-0.01%) ⬇️
recode-extension 57.56% <11.11%> (-0.01%) ⬇️
unit-7.1-ubuntu-latest 57.56% <11.11%> (-0.01%) ⬇️
unit-7.2-ubuntu-latest 57.73% <11.11%> (-0.01%) ⬇️
unit-7.3-ubuntu-latest 61.27% <11.11%> (-0.01%) ⬇️
unit-7.4-ubuntu-latest 61.27% <11.11%> (-0.01%) ⬇️
unit-8.0-ubuntu-latest 61.33% <11.11%> (-0.01%) ⬇️
unit-8.1-ubuntu-latest 61.21% <11.11%> (-0.01%) ⬇️
unit-nightly-ubuntu-latest 61.18% <11.11%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
libraries/classes/Session.php 10.97% <0.00%> (-0.57%) ⬇️
libraries/classes/Config.php 67.82% <33.33%> (-0.06%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 340bff0...2fd5540. Read the comment docs.

@MauricioFauth MauricioFauth merged commit 7582321 into phpmyadmin:QA_5_1 Feb 16, 2022
@MauricioFauth MauricioFauth deleted the session-cookie-samesite-php72 branch February 16, 2022 15:02
@MauricioFauth MauricioFauth added this to the 5.1.4 milestone Feb 16, 2022
@MauricioFauth MauricioFauth self-assigned this Feb 16, 2022
MauricioFauth added a commit that referenced this pull request Feb 16, 2022
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants