Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove jQuery SVG JS dependency #17494

Merged
merged 1 commit into from Apr 25, 2022

Conversation

MauricioFauth
Copy link
Member

@codecov
Copy link

codecov bot commented Apr 24, 2022

Codecov Report

Merging #17494 (5d80594) into QA_5_1 (b17700d) will increase coverage by 0.00%.
The diff coverage is 0.00%.

@@            Coverage Diff            @@
##             QA_5_1   #17494   +/-   ##
=========================================
  Coverage     57.91%   57.91%           
  Complexity    15417    15417           
=========================================
  Files           473      473           
  Lines         62162    62158    -4     
=========================================
  Hits          36000    36000           
+ Misses        26162    26158    -4     
Flag Coverage Δ
arch-7-amd64 58.64% <0.00%> (ø)
arch-7-arm32v6 58.51% <0.00%> (ø)
arch-7-arm32v7 58.51% <0.00%> (ø)
arch-7-arm64v8 58.64% <0.00%> (ø)
arch-7-i386 58.51% <0.00%> (ø)
arch-7-ppc64le 58.64% <0.00%> (ø)
arch-7-s390x 58.49% <0.00%> (ø)
dbase-extension 57.65% <0.00%> (+<0.01%) ⬆️
recode-extension 57.61% <0.00%> (+<0.01%) ⬆️
unit-7.1-ubuntu-latest 57.61% <0.00%> (+<0.01%) ⬆️
unit-7.2-ubuntu-latest 57.79% <0.00%> (+<0.01%) ⬆️
unit-7.3-ubuntu-latest 58.59% <0.00%> (ø)
unit-7.4-ubuntu-latest 58.59% <0.00%> (ø)
unit-8.0-ubuntu-latest 58.66% <0.00%> (ø)
unit-8.1-ubuntu-latest 58.61% <0.00%> (ø)
unit-nightly-ubuntu-latest 58.61% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...s/Controllers/Table/GisVisualizationController.php 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b17700d...5d80594. Read the comment docs.

Removed by phpmyadmin#17041.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
Copy link
Member

@williamdes williamdes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One less dependency 💯

@MauricioFauth MauricioFauth merged commit 0f13fe0 into phpmyadmin:QA_5_1 Apr 25, 2022
@MauricioFauth MauricioFauth deleted the jquery-svg branch April 25, 2022 20:17
@MauricioFauth MauricioFauth self-assigned this Apr 25, 2022
@MauricioFauth MauricioFauth added this to the 5.1.4 milestone Apr 25, 2022
@williamdes williamdes added the packaging An issue that affect Debian, Ubuntu or another form of packaging label Apr 25, 2022
MauricioFauth added a commit to MauricioFauth/phpmyadmin that referenced this pull request Apr 26, 2022
…yadmin#17445

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packaging An issue that affect Debian, Ubuntu or another form of packaging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants