Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove stickyfilljs JavaScript dependency #17499

Merged
merged 1 commit into from Apr 28, 2022

Conversation

MauricioFauth
Copy link
Member

@codecov
Copy link

codecov bot commented Apr 27, 2022

Codecov Report

Merging #17499 (54df014) into QA_5_2 (04f3f5a) will increase coverage by 0.03%.
The diff coverage is 14.28%.

@@             Coverage Diff              @@
##             QA_5_2   #17499      +/-   ##
============================================
+ Coverage     49.32%   49.36%   +0.03%     
  Complexity    16694    16694              
============================================
  Files           602      602              
  Lines         59756    59732      -24     
============================================
+ Hits          29477    29488      +11     
+ Misses        30279    30244      -35     
Flag Coverage Δ
dbase-extension 49.15% <14.28%> (+0.02%) ⬆️
recode-extension 47.89% <14.28%> (+0.01%) ⬆️
unit-7.2-ubuntu-latest 48.00% <14.28%> (+0.07%) ⬆️
unit-7.3-ubuntu-latest 50.34% <14.28%> (+1.23%) ⬆️
unit-7.4-ubuntu-latest 49.13% <14.28%> (+0.01%) ⬆️
unit-8.0-ubuntu-latest 49.23% <14.28%> (-0.01%) ⬇️
unit-8.1-ubuntu-latest 49.28% <14.28%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../classes/Controllers/Database/SearchController.php 0.00% <0.00%> (ø)
...ies/classes/Controllers/Database/SqlController.php 0.00% <0.00%> (ø)
...aries/classes/Controllers/Server/SqlController.php 0.00% <0.00%> (ø)
...ibraries/classes/Controllers/Sql/SqlController.php 0.00% <ø> (ø)
...ies/classes/Controllers/Table/ChangeController.php 0.00% <ø> (ø)
...ies/classes/Controllers/Table/SearchController.php 32.71% <ø> (ø)
...raries/classes/Controllers/Table/SqlController.php 0.00% <0.00%> (ø)
...classes/Controllers/Table/ZoomSearchController.php 0.00% <ø> (ø)
libraries/classes/Display/Results.php 60.62% <0.00%> (ø)
libraries/classes/Sql.php 47.05% <ø> (-0.01%) ⬇️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 04f3f5a...54df014. Read the comment docs.

This polyfill is not needed anymore.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
@MauricioFauth MauricioFauth merged commit d57530a into phpmyadmin:QA_5_2 Apr 28, 2022
@MauricioFauth MauricioFauth self-assigned this Apr 28, 2022
@MauricioFauth MauricioFauth added this to the 5.2.0 milestone Apr 28, 2022
@MauricioFauth MauricioFauth deleted the stickyfilljs branch April 28, 2022 13:54
@williamdes williamdes added the packaging An issue that affect Debian, Ubuntu or another form of packaging label Apr 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packaging An issue that affect Debian, Ubuntu or another form of packaging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants