New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove non working analyze explain button #17995
Remove non working analyze explain button #17995
Conversation
|
Can you ask them if they can open source it? |
Codecov ReportBase: 47.22% // Head: 47.72% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## QA_5_2 #17995 +/- ##
============================================
+ Coverage 47.22% 47.72% +0.49%
- Complexity 16825 16959 +134
============================================
Files 602 607 +5
Lines 71576 72301 +725
============================================
+ Hits 33805 34508 +703
- Misses 37771 37793 +22
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
662873d
to
d3527ff
Compare
Sure |
|
This would close: #17030 If they agree to open source it we can maybe make it internal. @MauricioFauth since it's broken it is okay to drop this link ? |
I think the button should be removed. |
|
Hi all, I am the Chief Contributions Officer for MariaDB Foundation. Sorry for the delay in responding to this. I have been on a long vacation over Christmas and New Year and have had to do a bit of research into the history of this tool. Unfortunately we cannot open source it in its current form. Due to a complicated history (that pre-dates the Foundation itself) we do not have the rights to do so and have been unsuccessful in obtaining them. That being said we at the Foundation do have access to the source code (currently written in Python 2) and do want to reverse engineer it into a new open source tool. We have not decided on a language or what form this will take yet. We are thinking some kind of library / cli with a JSON output. But are willing to work with the phpMyAdmin community on this if it is something useful. I'm more than happy to discuss this further as needed. |
Hi
Oh okay, thank you for making this clear.
We would be delighted to discuss about this and follow this new project. If we could embed the tool in phpMyAdmin I am sure the users would like it very much ! External services would lead to data leaks like it is reported in #17030 |
The service mariadb.org/explain_analyzer is unavailable. Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
d3527ff
to
79eacd6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅
Description
The service mariadb.org/explain_analyzer is unavailable.
I asked MariaDB via Slack and it's broken for a while.
Fixes: #17030
Before submitting pull request, please review the following checklist:
Signed-off-byline as described in our DCO. This ensures that the work you're submitting is your own creation.