Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved localization. #1807

Merged
merged 1 commit into from Jul 23, 2015
Merged

Improved localization. #1807

merged 1 commit into from Jul 23, 2015

Conversation

@udan11
Copy link
Member

@udan11 udan11 commented Jul 20, 2015

Improved localization.
Updated the sql-parser library to phpmyadmin/sql-parser@e5fc868.

I didn't get to test it. I will tomorrow.

I had to refactor the code a little bit to be able to use user's preferences (language selection).

Signed-off-by: Dan Ungureanu udan1107@gmail.com

@udan11
Copy link
Member Author

@udan11 udan11 commented Jul 21, 2015

Tested. Works fine after *.po and *.mo files are updated.

@lem9 lem9 self-assigned this Jul 21, 2015
@udan11
Copy link
Member Author

@udan11 udan11 commented Jul 21, 2015

It didn't find the messages because they weren't constants, but stored in variables. Now, I modified the library to use the __ function. I tried to make the library independent from the __ function, but it resulted in a complete mess. The new approach is better.

@lem9
Copy link
Contributor

@lem9 lem9 commented Jul 21, 2015

Please squash so I can have a better look.

@lem9
Copy link
Contributor

@lem9 lem9 commented Jul 22, 2015

Dan,
when I merge your branch to the current master branch and I try it, I have a problem. Let's say I type

SLECT

in the SQL query form. The hint on the red X says

Unexpected beginning of statement. (near %s)

So parameter subtitution does not happen.

Dan Ungureanu
Updated sql-parser library to phpmyadmin/sql-parser@e1b91ed.

Signed-off-by: Dan Ungureanu <udan1107@gmail.com>
@lem9
Copy link
Contributor

@lem9 lem9 commented Jul 23, 2015

Nice job.

lem9 added a commit that referenced this pull request Jul 23, 2015
Improved localization.
@lem9 lem9 merged commit b399665 into phpmyadmin:master Jul 23, 2015
3 of 4 checks passed
3 of 4 checks passed
coverage/coveralls Coverage pending from Coveralls.io
Details
Scrutinizer 6 new issues
Details
codacy/pr Good work! A positive commit.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@udan11 udan11 deleted the udan11:l10n branch Jul 23, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants