Skip to content

Allow opening server breadcrumb links in new tab with Ctrl/Meta key#19353

Merged
williamdes merged 2 commits intophpmyadmin:QA_5_2from
Smankusors:server-breadcrumb-new-tab
Jan 6, 2025
Merged

Allow opening server breadcrumb links in new tab with Ctrl/Meta key#19353
williamdes merged 2 commits intophpmyadmin:QA_5_2from
Smankusors:server-breadcrumb-new-tab

Conversation

@Smankusors
Copy link
Contributor

Description

Lately, I’ve been frustrated with this server breadcrumb, where opening a link in a new tab requires right-clicking and selecting "open in new tab" because the usual Ctrl/Meta key shortcut doesn’t work. So, I decided to fix it myself.

image


Before submitting pull request, please review the following checklist:

  • Make sure you have read our CONTRIBUTING.md document.
  • Make sure you are making a pull request against the correct branch. For example, for bug fixes in a released version use the corresponding QA branch and for new features use the master branch. If you have a doubt, you can ask as a comment in the bug report or on the mailing list.
  • Every commit has proper Signed-off-by line as described in our DCO. This ensures that the work you're submitting is your own creation.
  • Every commit has a descriptive commit message.
  • Every commit is needed on its own, if you have just minor fixes to previous commits, you can squash them.
  • Any new functionality is covered by tests.

Copy link
Member

@williamdes williamdes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MauricioFauth what do you think
should we send this to 5.2?

@williamdes williamdes force-pushed the server-breadcrumb-new-tab branch from 8bfde25 to edf8ec9 Compare January 6, 2025 02:22
@williamdes williamdes changed the base branch from master to QA_5_2 January 6, 2025 02:23
Copy link
Member

@williamdes williamdes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you !

@williamdes williamdes merged commit 6ce5636 into phpmyadmin:QA_5_2 Jan 6, 2025
1 check failed
@williamdes williamdes added this to the 5.2.2 milestone Jan 6, 2025
@williamdes williamdes added the Bug A problem or regression with an existing feature label Jan 6, 2025
@williamdes williamdes self-assigned this Jan 6, 2025
@williamdes
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug A problem or regression with an existing feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants