Reserved words issue #216

Merged
merged 2 commits into from Mar 21, 2013

Projects

None yet

2 participants

@ayushchd
Contributor

The configuration is now set to display the warning by default. Config has been documented in config.rst and config can also be changed from the Features settings under the 'Warnings' tab

@ayushchd ayushchd Reserved word warning config
This commit removes reserved word warning from the Browse pages and the
warning on structure page can be switched on/off using the config
variable $cfg['ReservedWordWarning']
665ffd4
@lem9

It's not an easy choice to pick up a default value but I think the community would be best served by setting this to true.

@lem9

When adding a new directive, you should document it. This is done in doc/config.rst and I suggest adding a short paragraph in the Generic settings section.

It would be interesting also to offer the user a chance to change the directive, via the user prefs module (the "More settings" link on home page). Can you take care of these two issues?

Owner

Okay, I'll do that.

@ayushchd ayushchd Added ability to disable MySQL reserved word warning
Disable MySQL reserved word warning $cfg['ReservedWordDisableWarning'],
documentation and ability to change from prefs pane
27967e7
@lem9 lem9 was assigned Mar 21, 2013
@lem9
Contributor
lem9 commented Mar 21, 2013

Good job!

@lem9 lem9 merged commit b48affc into phpmyadmin:master Mar 21, 2013

1 check passed

default The Travis build passed
Details
@ayushchd
Contributor

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment