Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix for #3881. "Escaped html in error message" #283

Closed
wants to merge 2 commits into from

Conversation

ayusun
Copy link
Contributor

@ayusun ayusun commented Apr 24, 2013

The reason for the bug is the post request for "import.php" by *_import.php files. So, in this case after logging in, the target variable in the GET REQUEST was always set to import.php and thus PMA was redirected to import.php. But import the php used two parameters import_type and format which when checked in the checkparameters function resulted in fatal error.

The changes that i made were, before redirecting if the request was for import.php in the code of index.php, if true i used session variable to state that i am doing some redirection(this variable can be pretty helpful if in future we have some more legacy submissions like for import.php) and in session variable i check it if it's true or not,

If true then just redirect the code to the last url where we were(which is also stored in session, could have used $GLOBALS but the seems to be reloaded by the common.inc.php, so used sessions)

@ghost ghost assigned lem9 Apr 26, 2013
@ghost ghost assigned lem9 May 6, 2013
@lem9
Copy link
Contributor

lem9 commented May 8, 2013

Closing for now, as Herman mentions a problem with this patch in https://sourceforge.net/p/phpmyadmin/bugs/3881

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants