Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Move columns #31

Merged
merged 8 commits into from Apr 25, 2012

Conversation

Projects
None yet
2 participants
Contributor

ZweiSteinSoft commented Apr 14, 2012

No description provided.

Contributor

lem9 commented Apr 14, 2012

Jo,
tested with a table having two columns, in FF 11.0 / Vista. After moving and clicking on Go, I get this in Firebug's console:

event is not defined (tbl_structure.js, line 379)

Please look for an already existing function that does a similar job, like PMA_DBI_get_columns_full(), to see if we could not reuse code.

One of the problems with this code is that if the server's SQL mode is ANSI_QUOTES, there are no backticks around identifiers. Try
git grep ANSI_QUOTES

Is the definition created here complete in all cases?

lem9 replied Apr 21, 2012

Jo,
did you consider using PMA_Table::generateAlter() instead?

Contributor

ZweiSteinSoft commented Apr 22, 2012

However, this new version needs more lines…

@ghost ghost assigned lem9 Apr 23, 2012

Contributor

lem9 commented Apr 23, 2012

Jo,
yes it needs more lines but I think it's better to call a common function.

If there are no comment for this column, $data['Comments'] won't be defined; I suggest testing with
isset($data['Comments'])

Owner

ZweiSteinSoft replied Apr 24, 2012

Done in 93f918a.

lem9 commented on cdfe73d Apr 23, 2012

With sakila.actor, moving "last_update" gives "invalid default value".

Owner

ZweiSteinSoft replied Apr 24, 2012

That was due to the 'on update CURRENT_TIMESTAMP'. Fixed in f76f092.

@lem9 lem9 merged commit f76f092 into phpmyadmin:master Apr 25, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment