Fix most analysis results discovered in bug 3907

[ZweiSteinSoft]

Thanks @rlerdorf!

[lem9]

Good job! I'm now fixing merge conflicts to master.

Apart from running hhvm, is there a way to know what remains to be fixed?

[rlerdorf]

I can run it again if you like. Let me know which branch to run it against.

[lem9]

@rlerdorf you're very kind. Please run it on branches QA_4_0 and master.

[rlerdorf]

Here it is for QA_4_0 (only lightly filtered, so there could be false positives): https://gist.github.com/5585791
And for master: https://gist.github.com/5585809

[lem9]

I have removed the dead code from QA_4_0 and master, which referred to unknown functions in replication.inc.php.

[lem9]

Fixed:
libraries/rte/rte_export.lib.php
libraries/sql.lib.php
server_status_queries.php
libraries/Config.class.php

[ZweiSteinSoft]

Fixed another one in e4199c1.

[ZweiSteinSoft]

The other issues originate from TCPDF and php-gettext. @rlerdorf, we can't fix them ourselves. Did you get round to posting a report on Launchpad, for php-gettext?