refactor server_binlog.php:1. split to functions 2. move function to server_bin_log.lib.php #404

Merged
merged 3 commits into from Jun 7, 2013

Projects

None yet

2 participants

@xmujay
  1. split to functions
  2. move function to server_bin_log.lib.php
xmujay added some commits Jun 6, 2013
@xmujay xmujay refactor server_binlog.php:
1. split to functions
2. move function to server_bin_log.lib.php
77318c0
@xmujay xmujay fix code indention 222c432
@lem9 lem9 was assigned Jun 6, 2013
@lem9

Good work in general, I'll add a few comments for small improvements.

@lem9

These are not really binary logs but binary logs file names, so I suggest to rename to $binary_log_file_names.

@lem9

Please fix the old typo "we do not now" -> "we do not know"

@lem9

Function is still quite long, maybe extract these parts:

  • the section inside the "while"
  • the section that handles the big T and the Previous/Next arrows.
@xmujay

Hi Marc, I have fixed the issues you mentioned. I will take care of these kinds of issues myself future. thanks for your review.

@lem9 lem9 merged commit 7496c0a into phpmyadmin:master Jun 7, 2013

1 check passed

Details default The Travis CI build passed
@lem9

Excellent!

@lem9

Please remove the tab characters from libraries/server_bin_log.lib.php.

@lem9

By the way, I don't see why $binary_logs is generated in server_common.inc.php, please move it to server_binlog.php.

@xmujay

Hi Marc, I fix the two issues in #405/

  1. remove tab
  2. move $binary_logs to server_binlog.php
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment