1. split to functions
2. move function to server_bin_log.lib.php
fix code indention
Good work in general, I'll add a few comments for small improvements.
These are not really binary logs but binary logs file names, so I suggest to rename to $binary_log_file_names.
Please fix the old typo "we do not now" -> "we do not know"
Function is still quite long, maybe extract these parts:
split navigation and item render from long function
Hi Marc, I have fixed the issues you mentioned. I will take care of these kinds of issues myself future. thanks for your review.
Please remove the tab characters from libraries/server_bin_log.lib.php.
By the way, I don't see why $binary_logs is generated in server_common.inc.php, please move it to server_binlog.php.
Hi Marc, I fix the two issues in #405/