refactor server_plugins.php: #405

Merged
merged 5 commits into from Jun 7, 2013

2 participants

@xmujay
  1. change HTML mixture to php
  2. change long code to functions
  3. move functions to libraries/server_plugins.lib.php
xmujay added some commits Jun 7, 2013
@xmujay xmujay refactor server_plugins.php:
1. change HTML mixture to php
2. change long code to functions
3. move functions to libraries/server_plugins.lib.php
fb72aaa
@xmujay xmujay fix code indention c745ac4
@xmujay xmujay using space instead of Tab a20ba08
@lem9 lem9 was assigned Jun 7, 2013
@lem9

This is similar from the function in libraries/server_bin_log.lib.php. Please extract this to a common function and move it to a new libraries/server_common.lib.php.

Refactoring also means removing similar code.

@xmujay

Hi Marc, I have move PMA_getSubPageHeader to server_common.inc.php. thanks for your review.

@lem9

Bin,
no, it should go to a new server_common.lib.php. Files ending with .inc.php are supposed to contain code outside of functions, and files ending with .lib.php are supposed to hold functions only.

@xmujay xmujay fix the issues:
1. replace tab with space in server_bin_log.lib.php
2. move $bin_log to server_binlog.php
3. add server common function file server_common.lib.php
bfb6dec
@xmujay

Hi Marc, I add server_common.lib.php to store server common function

@lem9

Good job. I don't have a Drizzle server at the moment, but I'm merging this and will try to test on the demo server later.

@lem9 lem9 merged commit c859ddd into phpmyadmin:master Jun 7, 2013

1 check passed

Details default The Travis CI build passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment