1. change HTML mixture to php
2. change long code to functions
3. move functions to libraries/server_plugins.lib.php
fix code indention
using space instead of Tab
This is similar from the function in libraries/server_bin_log.lib.php. Please extract this to a common function and move it to a new libraries/server_common.lib.php.
Refactoring also means removing similar code.
move PMA_getSubPageHeader to server_common.inc.php
Hi Marc, I have move PMA_getSubPageHeader to server_common.inc.php. thanks for your review.
no, it should go to a new server_common.lib.php. Files ending with .inc.php are supposed to contain code outside of functions, and files ending with .lib.php are supposed to hold functions only.
fix the issues:
1. replace tab with space in server_bin_log.lib.php
2. move $bin_log to server_binlog.php
3. add server common function file server_common.lib.php
Hi Marc, I add server_common.lib.php to store server common function
Good job. I don't have a Drizzle server at the moment, but I'm merging this and will try to test on the demo server later.