add test for transformation class: Text_Plain_Append #413

Merged
merged 2 commits into from Jun 12, 2013

Projects

None yet

2 participants

@adamgsoc2013
Contributor

No description provided.

@nijel nijel commented on an outdated diff Jun 11, 2013
...ses/plugin/transformations/Text_Plain_Append_test.php
+class Text_Plain_Append_Test extends PHPUnit_Framework_TestCase
+{
+ /**
+ * Test for getInfo
+ *
+ * @return void
+ *
+ * @group medium
+ */
+ public function testGetInfo()
+ {
+ $info = 'Appends text to a string. The only option is the text to be appended'
+ . ' (enclosed in single quotes, default empty string).';
+ $this->assertEquals(
+ $info,
+ Text_Plain_Append_getInfo()
@nijel
nijel Jun 11, 2013 Member

Rather test Text_Plain_Append::getInfo, this function is there only for workarounding PHP bug.

@nijel
Member
nijel commented Jun 11, 2013

Again, this test does not cover any functionality of the class, please do that testing as well.

@adamgsoc2013
Contributor

all right, I just cover some common functions firstly. I will add more function cover later. thanks

@nijel nijel merged commit fc494c2 into phpmyadmin:master Jun 12, 2013

1 check passed

default The Travis CI build passed
Details
@nijel
Member
nijel commented Jun 12, 2013

Okay, I've merged this, but I'd prefer to have these simple classes fully covered when merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment