1. add test case for sub class of schema 2. refactor the code for better UT coverage #419

Closed
wants to merge 3 commits into
from

Projects

None yet

2 participants

@adamgsoc2013
Contributor

refactor the code for better UT coverage

  1. change class Table_Stats to Table_Stats_$type
  2. change class Relation_Stats to Relation_Stats_$type
@adamgsoc2013 adamgsoc2013 add test case for sub class of schema
refactor the code for better UT coverage
1. change class Table_Stats to Table_Stats_$type
2. change class Relation_Stats to Relation_Stats_$type
5ed324e
@adamgsoc2013
Contributor

Hi Michal, I found that the source code

https://github.com/phpmyadmin/phpmyadmin/blob/master/libraries/schema/Dia_Relation_Schema.class.php#L766

the "exit" will make the UT run exit unexpectedly, can we remove "exit" ? thanks

@adamgsoc2013
Contributor

same with all sub class of schema

@nijel
Member
nijel commented Jun 12, 2013

I have no clue whether schema rendering will work then, can you check
what is needed that it will?

@adamgsoc2013
Contributor

thanks Michal,

Close it for more investigation since the block of unit testing.

will reopen when things are ready. thanks

@adamgsoc2013 adamgsoc2013 reopened this Jun 13, 2013
@adamgsoc2013
Contributor

Hi Michial, I have tested it is ok to remove the "exit()" statement.the usage of every sub-class of PMA_Export_Relation_Schema is when export the table's schema.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment