unit test case for server_binlog newly refactored functions #479

Merged
merged 1 commit into from Jul 3, 2013

Conversation

Projects
None yet
2 participants
Contributor

xmujay commented Jul 3, 2013

Hi Marc, this pull request will cover all server_binlog newly refactored functions
I verify that:

  1. the sql has been executed
  2. important BINLOG HTML
  3. PMA_getNavigationRow is right
  4. important Log Item

add Michal, who always review the code for UT

@ghost ghost assigned lem9 Jul 3, 2013

Contributor

lem9 commented Jul 3, 2013

Hi Bin,
Michal is on vacation for a few days.

Seems OK to me, merging.

lem9 added a commit that referenced this pull request Jul 3, 2013

Merge pull request #479 from xmujay/0629_UT_serverview2
unit test case for server_binlog newly refactored functions

@lem9 lem9 merged commit c9cee99 into phpmyadmin:master Jul 3, 2013

1 check passed

default The Travis CI build passed
Details
Contributor

lem9 commented Jul 3, 2013

I renamed the file: 1f4e366

Contributor

xmujay commented Jul 4, 2013

thanks Marc, today I will post some other files' UT to cover the refactored functions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment