Unit test case for refactored functions: PMA_server_engines #482

Merged
merged 5 commits into from Jul 6, 2013

Conversation

Projects
None yet
2 participants
@xmujay
Contributor

xmujay commented Jul 6, 2013

No description provided.

@xmujay

This comment has been minimized.

Show comment Hide comment
@xmujay

xmujay Jul 6, 2013

Contributor

Hi Marc, this is for Unit test case for PMA_server_engines, thanks

Contributor

xmujay commented Jul 6, 2013

Hi Marc, this is for Unit test case for PMA_server_engines, thanks

@xmujay xmujay closed this Jul 6, 2013

@xmujay xmujay reopened this Jul 6, 2013

@xmujay

This comment has been minimized.

Show comment Hide comment
@xmujay

xmujay Jul 6, 2013

Contributor

Hi Marc, in the latest build I moved the mock data to DBI dummy class, this is a formal way in PMA. Now all cases have passed. can you help to have a review? thanks

Contributor

xmujay commented Jul 6, 2013

Hi Marc, in the latest build I moved the mock data to DBI dummy class, this is a formal way in PMA. Now all cases have passed. can you help to have a review? thanks

@ghost ghost assigned lem9 Jul 6, 2013

@lem9

This comment has been minimized.

Show comment Hide comment
@lem9

lem9 Jul 6, 2013

Contributor

Hi Bin,
phpcs finds 6 errors and 1 warning in test/libraries/PMA_server_engines_test.php.

Contributor

lem9 commented Jul 6, 2013

Hi Bin,
phpcs finds 6 errors and 1 warning in test/libraries/PMA_server_engines_test.php.

@xmujay

This comment has been minimized.

Show comment Hide comment
@xmujay

xmujay Jul 6, 2013

Contributor

Hi Marc, I have fixed all the code style for my new added UT files. thanks for review.

Contributor

xmujay commented Jul 6, 2013

Hi Marc, I have fixed all the code style for my new added UT files. thanks for review.

lem9 added a commit that referenced this pull request Jul 6, 2013

Merge pull request #482 from xmujay/0629_UT_serverview2
Unit test case for refactored functions: PMA_server_engines

@lem9 lem9 merged commit 430e439 into phpmyadmin:master Jul 6, 2013

1 check passed

default The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment