Skip to content

unit test case for server_status newly refactored functions #486

Merged
merged 6 commits into from Jul 9, 2013

3 participants

@xmujay
xmujay commented Jul 8, 2013

No description provided.

@lem9 lem9 was assigned Jul 8, 2013
@xmujay
xmujay commented Jul 8, 2013

Hi Marc, this pull request will cover the Unit test for server view refactored files: PMA_server_status_variables and PMA_server_status_monitor. thanks for your reviews

@lem9
lem9 commented Jul 8, 2013

Hi Bin,
phpcs says: test/libraries/PMA_server_status_variables_test.php

24 | ERROR | Missing class doc comment

@xmujay
xmujay commented Jul 9, 2013

Hi Marc, I added "class doc comment" for all the UT files.

but the following errors existed on all PMA files:
7 | ERROR | Missing @category tag in file comment
7 | ERROR | Missing @author tag in file comment
7 | ERROR | Missing @license tag in file comment
7 | ERROR | Missing @link tag in file comment

@nijel
phpMyAdmin member
nijel commented Jul 9, 2013
@xmujay
xmujay commented Jul 9, 2013

thanks, so I think all Code style issues have been fixed, thanks

@lem9 lem9 merged commit bf34732 into phpmyadmin:master Jul 9, 2013

1 check passed

Details default The Travis CI build passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.