No description provided.
refactor the code style of server_export
fix the undefined error
Merge branch 'master' of https://github.com/phpmyadmin/phpmyadmin int…
fix undefined variable: multi_values
this pull request is to refactor server_export, including:
1. split functions to server_export.lib.php
2. split long functions to small functions
3. render html at once
4. fix code style
I have started reviewing this code and will continue tomorrow. For now, just a remark. I think that all your new functions should not go to libraries/server_export.lib.php. The reason is that this code can be used for export at the server, database and table level, so a better filename to hold these functions is libraries/display_export.lib.php. You'll notice that this file exists, but it should have been named libraries/display_export.inc.php because it mostly contains non-functional code. I hope I am clear enough.
rename server_export.lib.php to display_export.lib.php due to it work…
…s for server and database, table level export
thanks Marc for your careful review.
I have noticed that display_export.lib.php is used by database, server and table.
in the latest commit,
1. I rename display_export.lib.php to display_export.inc.php
2. rename server_export.lib.php to display_export.lib.php
3. also change the include files.
I have tested on database, server and table level export