Refactoring tbl_change.php #552

merged 15 commits into from Jul 31, 2013

2 participants


Hi Marc,
I have refactored some parts of the tbl_change.php using extract method in this pull request.

@lem9 lem9 was assigned Jul 30, 2013

I'm not sure that this is not used. There are some libraries that are using global $analyzed_sql (which is not a good idea but it's the current state of the code base).

But for the moment the tests are fine so it might be acceptable to remove it,


If the UploadDir directive is defined in, and your table contains a BLOB column, this library is used to list the files present in the upload directory, to be able to upload one of them inside the BLOB.


You explained only $disp_message and lost the $disp_query question.

the $disp_query is not used in the bellow code. So I thought it is not required to mention about it here.



Supun, I found a bug:

  • click on Insert for a table
  • click on the Function header: you should stay on the insert page, but remove the Function fields, but a different page is displayed
  • same problem for the Type header

Nice work!

@lem9 lem9 merged commit 52a9edf into phpmyadmin:master Jul 31, 2013

1 check passed

Details default The Travis CI build passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment