Refactoring tbl_columns_definition_form.inc.php #557

Merged
merged 1 commit into from Jul 31, 2013

Conversation

Projects
None yet
2 participants
Contributor

scnakandala commented Jul 31, 2013

Hi Marc,
I have added a new library file and extracted some functions using extract method.

@scnakandala scnakandala added libraries/tbl_columns_definition_form.lib.php . Added methods P…
…MA_getFormsParameters, PMA_getHtmlForTableConfigurations, PMA_getHtmlForFooter, PMA_getHtmlForTableNameAndNoOfColumns, PMA_getHtmlForTableFieldDefinitions, PMA_getHtmlForTableCreateOrAddField
ca26894

lem9 was assigned Jul 31, 2013

Contributor

lem9 commented Jul 31, 2013

Hi Supun,
I appreciate your new branch names.

Contributor

lem9 commented Jul 31, 2013

Nice work. The $true_selected stuff is a feature that got lost on the way, I'll take care of it later.

@lem9 lem9 added a commit that referenced this pull request Jul 31, 2013

@lem9 lem9 Merge pull request #557 from scnakandala/refac_tbl_columns_definitions
Refactoring tbl_columns_definition_form.inc.php
796e72f

@lem9 lem9 merged commit 796e72f into phpmyadmin:master Jul 31, 2013

1 check passed

default The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment