Refac tbl columns definitions #569

Closed
wants to merge 19 commits into
from

Projects

None yet

2 participants

@scnakandala

extracted all code producing html code to methods

@lem9 lem9 was assigned Aug 5, 2013
@lem9
lem9 commented Aug 6, 2013

Supun,
Michal has made some fixes:
a3ce1cc
ff046ce
Please merge them and resolve conflitcs.

@lem9

Incorrect change due to massive $i change.

@lem9
lem9 commented Aug 6, 2013

Supun,
I think it's better to close for now, reopen when you have completed the changes.

@lem9 lem9 closed this Aug 6, 2013
@scnakandala

Marc,
Regarding the function renaming. Is it ok to proceed with my suggestion
PMA_getRowDataForFieldsMetaSet => PMA_getColumnDataForChange ?

On Tue, Aug 6, 2013 at 10:14 PM, Marc Delisle notifications@github.comwrote:

Supun,
I think it's better to close for now, reopen when you have completed the
changes.


Reply to this email directly or view it on GitHubhttps://github.com/phpmyadmin/phpmyadmin/pull/569#issuecomment-22193108
.

Thank you
Supun Nakandala
Dept. Computer Science and Engineering
University of Moratuwa

@lem9
lem9 commented Aug 6, 2013

Supun,
I suggest PMA_getColumnMetaForDefault.

@Tithugues Tithugues added a commit to Tithugues/phpmyadmin that referenced this pull request Feb 23, 2014
@Tithugues Tithugues Feature #569 Load/Save Query By Example
Implement possibility to save/load/delete a QBE on a DB.

Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
8b84cf0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment